-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21245] Fix topic interference on liveliness_changed
status
#4988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EduPonz
suggested changes
Jun 25, 2024
MiguelCompany
force-pushed
the
bugfix/21189/master
branch
from
June 25, 2024 10:35
a875bb7
to
30f69e5
Compare
EduPonz
previously approved these changes
Jun 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
EduPonz
previously approved these changes
Jun 25, 2024
MiguelCompany
force-pushed
the
bugfix/21189/master
branch
from
June 25, 2024 15:04
3c11718
to
b137c03
Compare
EduPonz
previously approved these changes
Jun 26, 2024
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
MiguelCompany
force-pushed
the
bugfix/21189/master
branch
from
July 3, 2024 14:40
a6444d7
to
95865e4
Compare
MiguelCompany
added
needs-review
PR that is ready to be reviewed
and removed
to-do
ci-pending
PR which CI is running
labels
Jul 3, 2024
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
EduPonz
approved these changes
Jul 4, 2024
@Mergifyio backport 2.14.x |
🛑 Command
|
@Mergifyio backport 2.14.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 4, 2024
* Refs #21189. Basic infrastructure for ROS2 blackbox tests. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Added callback for liveliness_changed event. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Added ROS2 regression test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Added blackbox regression test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Fix StatefulReader. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Fix StatelessReader. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Uncrustify and doxygen. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Change liveliness announcement periods. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Create ROS 2 builtin endpoints. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Fix type and QoS on ros_discovery_info. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Avoid collision with true ROS 2 topics. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Uncrustify. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Fix warnings on MacOS. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Fix tsan reported deadlock. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Fix long-standing deadlock in WLP. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Fix build after rebase. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 9243ead) # Conflicts: # src/cpp/rtps/reader/StatefulReader.cpp # src/cpp/rtps/reader/StatelessReader.cpp # test/blackbox/common/BlackboxTestsLivelinessQos.cpp
12 tasks
EduPonz
pushed a commit
that referenced
this pull request
Jul 9, 2024
* Fix topic interference on `liveliness_changed` status (#4988) * Refs #21189. Basic infrastructure for ROS2 blackbox tests. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Added callback for liveliness_changed event. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Added ROS2 regression test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Added blackbox regression test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Fix StatefulReader. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Fix StatelessReader. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Uncrustify and doxygen. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Change liveliness announcement periods. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Create ROS 2 builtin endpoints. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Fix type and QoS on ros_discovery_info. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Avoid collision with true ROS 2 topics. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Uncrustify. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Fix warnings on MacOS. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Fix tsan reported deadlock. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Fix long-standing deadlock in WLP. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Fix build after rebase. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 9243ead) # Conflicts: # src/cpp/rtps/reader/StatefulReader.cpp # src/cpp/rtps/reader/StatelessReader.cpp # test/blackbox/common/BlackboxTestsLivelinessQos.cpp * Fix conflicts Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Fix build after backport. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
mergify bot
added a commit
that referenced
this pull request
Jul 9, 2024
* Fix topic interference on `liveliness_changed` status (#4988) * Refs #21189. Basic infrastructure for ROS2 blackbox tests. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Added callback for liveliness_changed event. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Added ROS2 regression test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Added blackbox regression test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Fix StatefulReader. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Fix StatelessReader. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Uncrustify and doxygen. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Change liveliness announcement periods. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Create ROS 2 builtin endpoints. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Fix type and QoS on ros_discovery_info. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Avoid collision with true ROS 2 topics. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Uncrustify. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Fix warnings on MacOS. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Fix tsan reported deadlock. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Fix long-standing deadlock in WLP. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Fix build after rebase. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 9243ead) # Conflicts: # src/cpp/rtps/reader/StatefulReader.cpp # src/cpp/rtps/reader/StatelessReader.cpp # test/blackbox/common/BlackboxTestsLivelinessQos.cpp * Fix conflicts Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Fix build after backport. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 4a6b934)
mergify bot
added a commit
that referenced
this pull request
Jul 9, 2024
* Fix topic interference on `liveliness_changed` status (#4988) * Refs #21189. Basic infrastructure for ROS2 blackbox tests. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Added callback for liveliness_changed event. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Added ROS2 regression test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Added blackbox regression test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Fix StatefulReader. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Fix StatelessReader. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Uncrustify and doxygen. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Change liveliness announcement periods. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Create ROS 2 builtin endpoints. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Fix type and QoS on ros_discovery_info. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Avoid collision with true ROS 2 topics. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Uncrustify. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Fix warnings on MacOS. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Fix tsan reported deadlock. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Fix long-standing deadlock in WLP. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Fix build after rebase. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 9243ead) # Conflicts: # src/cpp/rtps/reader/StatefulReader.cpp # src/cpp/rtps/reader/StatelessReader.cpp # test/blackbox/common/BlackboxTestsLivelinessQos.cpp * Fix conflicts Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Fix build after backport. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 4a6b934) # Conflicts: # src/cpp/rtps/reader/StatelessReader.cpp
mergify bot
added a commit
that referenced
this pull request
Jul 9, 2024
* Fix topic interference on `liveliness_changed` status (#4988) * Refs #21189. Basic infrastructure for ROS2 blackbox tests. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Added callback for liveliness_changed event. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Added ROS2 regression test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Added blackbox regression test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Fix StatefulReader. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Fix StatelessReader. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Uncrustify and doxygen. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Change liveliness announcement periods. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Create ROS 2 builtin endpoints. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Fix type and QoS on ros_discovery_info. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Avoid collision with true ROS 2 topics. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Uncrustify. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Fix warnings on MacOS. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Fix tsan reported deadlock. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Fix long-standing deadlock in WLP. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Fix build after rebase. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 9243ead) # Conflicts: # src/cpp/rtps/reader/StatefulReader.cpp # src/cpp/rtps/reader/StatelessReader.cpp # test/blackbox/common/BlackboxTestsLivelinessQos.cpp * Fix conflicts Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Fix build after backport. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 4a6b934) # Conflicts: # src/cpp/rtps/reader/StatefulReader.cpp # src/cpp/rtps/reader/StatelessReader.cpp
Open
12 tasks
EduPonz
pushed a commit
that referenced
this pull request
Jul 10, 2024
…#5044) * Fix topic interference on `liveliness_changed` status (#4988) * Refs #21189. Basic infrastructure for ROS2 blackbox tests. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Added callback for liveliness_changed event. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Added ROS2 regression test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Added blackbox regression test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Fix StatefulReader. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Fix StatelessReader. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Uncrustify and doxygen. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Change liveliness announcement periods. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Create ROS 2 builtin endpoints. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Fix type and QoS on ros_discovery_info. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Avoid collision with true ROS 2 topics. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Uncrustify. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Fix warnings on MacOS. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Fix tsan reported deadlock. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Fix long-standing deadlock in WLP. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Fix build after rebase. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 9243ead) # Conflicts: # src/cpp/rtps/reader/StatefulReader.cpp # src/cpp/rtps/reader/StatelessReader.cpp # test/blackbox/common/BlackboxTestsLivelinessQos.cpp * Fix conflicts Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Fix build after backport. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 4a6b934) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
MiguelCompany
pushed a commit
that referenced
this pull request
Jul 31, 2024
* Fix topic interference on `liveliness_changed` status (#4988) * Refs #21189. Basic infrastructure for ROS2 blackbox tests. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Added callback for liveliness_changed event. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Added ROS2 regression test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Added blackbox regression test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Fix StatefulReader. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Fix StatelessReader. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Uncrustify and doxygen. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Change liveliness announcement periods. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Create ROS 2 builtin endpoints. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Fix type and QoS on ros_discovery_info. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Avoid collision with true ROS 2 topics. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Uncrustify. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Fix warnings on MacOS. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Fix tsan reported deadlock. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Fix long-standing deadlock in WLP. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Fix build after rebase. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 9243ead) # Conflicts: # src/cpp/rtps/reader/StatefulReader.cpp # src/cpp/rtps/reader/StatelessReader.cpp # test/blackbox/common/BlackboxTestsLivelinessQos.cpp * Fix conflicts Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Fix build after backport. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 4a6b934) # Conflicts: # src/cpp/rtps/reader/StatelessReader.cpp
MiguelCompany
pushed a commit
that referenced
this pull request
Aug 19, 2024
…#5045) * Fix topic interference on `liveliness_changed` status (#4988) * Refs #21189. Basic infrastructure for ROS2 blackbox tests. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Added callback for liveliness_changed event. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Added ROS2 regression test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Added blackbox regression test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Fix StatefulReader. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Fix StatelessReader. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Uncrustify and doxygen. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Change liveliness announcement periods. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Create ROS 2 builtin endpoints. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Fix type and QoS on ros_discovery_info. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Avoid collision with true ROS 2 topics. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Uncrustify. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Fix warnings on MacOS. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Fix tsan reported deadlock. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Fix long-standing deadlock in WLP. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Fix build after rebase. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 9243ead) # Conflicts: # src/cpp/rtps/reader/StatefulReader.cpp # src/cpp/rtps/reader/StatelessReader.cpp # test/blackbox/common/BlackboxTestsLivelinessQos.cpp * Fix conflicts Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Fix build after backport. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 4a6b934) # Conflicts: # src/cpp/rtps/reader/StatelessReader.cpp Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Mario-DL
pushed a commit
that referenced
this pull request
Oct 9, 2024
* Fix topic interference on `liveliness_changed` status (#4988) * Refs #21189. Basic infrastructure for ROS2 blackbox tests. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Added callback for liveliness_changed event. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Added ROS2 regression test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Added blackbox regression test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Fix StatefulReader. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Fix StatelessReader. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Uncrustify and doxygen. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Change liveliness announcement periods. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Create ROS 2 builtin endpoints. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Fix type and QoS on ros_discovery_info. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Avoid collision with true ROS 2 topics. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Uncrustify. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Fix warnings on MacOS. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Fix tsan reported deadlock. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Fix long-standing deadlock in WLP. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Fix build after rebase. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 9243ead) * Fix conflicts Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Fix build after backport. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 4a6b934)
Mario-DL
pushed a commit
that referenced
this pull request
Oct 9, 2024
* Fix topic interference on `liveliness_changed` status (#4988) * Refs #21189. Basic infrastructure for ROS2 blackbox tests. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Added callback for liveliness_changed event. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Added ROS2 regression test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Added blackbox regression test. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Fix StatefulReader. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Fix StatelessReader. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Uncrustify and doxygen. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Change liveliness announcement periods. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Create ROS 2 builtin endpoints. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Fix type and QoS on ros_discovery_info. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Avoid collision with true ROS 2 topics. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Uncrustify. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Fix warnings on MacOS. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21245. Fix tsan reported deadlock. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Fix long-standing deadlock in WLP. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #21189. Fix build after rebase. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 9243ead) * Fix conflicts Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Fix build after backport. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 4a6b934)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR #4822 (and its backports) introduced a regression that was not detected until we requested ROS 2 rolling to use branch 2.14.x here
This PR:
@Mergifyio backport 2.14.x 2.13.x 2.10.x 2.6.x
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist