Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21292] Fix compilation in Ubuntu 24.04 platforms #4987

Merged
merged 1 commit into from
Jun 25, 2024
Merged

[21292] Fix compilation in Ubuntu 24.04 platforms #4987

merged 1 commit into from
Jun 25, 2024

Conversation

Carlosespicur
Copy link
Contributor

@Carlosespicur Carlosespicur commented Jun 24, 2024 •
edited by EduPonz
Loading

Description

A Ubuntu 24 issue in FastDDS compilation. This Pull Request fix the issue described.

@Mergifyio backport 2.14.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Carlosespicur
Fix compilation in Ubuntu 22.04 platforms
90093a2 
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
@EduPonz EduPonz changed the title Fix compilation in Ubuntu 22.04 platforms Fix compilation in Ubuntu 24.04 platforms Jun 24, 2024
@EduPonz EduPonz added the no-test Skip CI tests if PR marked with this label label Jun 24, 2024
@EduPonz EduPonz self-requested a review June 24, 2024 13:00
@github-actions github-actions bot added the ci-pending PR which CI is running label Jun 24, 2024
@EduPonz EduPonz added this to the v3.0.0 milestone Jun 24, 2024
@EduPonz
Copy link

EduPonz commented Jun 24, 2024

@Mergifyio backport 2.14.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 24, 2024 •
edited
Loading

backport 2.14.x

✅ Backports have been created

@EduPonz EduPonz merged commit f835c2e into master Jun 25, 2024
13 of 14 checks passed
@EduPonz EduPonz deleted the hotfix/ubuntu24-build branch June 25, 2024 05:35
mergify bot pushed a commit that referenced this pull request Jun 25, 2024
@Carlosespicur @mergify
Fix compilation in Ubuntu 22.04 platforms (#4987)
33e9e35 
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
(cherry picked from commit f835c2e)
@mergify mergify bot mentioned this pull request Jun 25, 2024
Merged
8 tasks
EduPonz pushed a commit that referenced this pull request Jun 25, 2024
@mergify @Carlosespicur
Fix compilation in Ubuntu 22.04 platforms (#4987) (#4992)
95a1481 
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
(cherry picked from commit f835c2e)

Co-authored-by: Carlos Espinoza Curto <148376273+Carlosespicur@users.noreply.github.com>
@rsanchez15 rsanchez15 changed the title Fix compilation in Ubuntu 24.04 platforms [21292] Fix compilation in Ubuntu 24.04 platforms Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz approved these changes

Assignees
No one assigned
Labels
ci-pending PR which CI is running no-test Skip CI tests if PR marked with this label
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Carlosespicur @EduPonz