Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve X-Types interoperability #4985

Merged
merged 7 commits into from
Jul 9, 2024
Merged

Improve X-Types interoperability #4985

merged 7 commits into from
Jul 9, 2024

Conversation

richiware
Copy link
Member

@richiware richiware commented Jun 24, 2024

Description

This PR brings:

  • Changes in some IDL files to improve X-Types interoperability.
  • Not taking into account the TypeInformation from other vendors.

Depends on:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@richiware richiware force-pushed the feature/21222 branch 2 times, most recently from e3b740d to 3fdb2a8 Compare July 4, 2024 09:49
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 5, 2024
@MiguelCompany MiguelCompany removed the needs-review PR that is ready to be reviewed label Jul 8, 2024
@MiguelCompany
Copy link
Member

There have been some failures which I don't know if they are related.

@richiware Would you mind rebasing just in case?

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@EduPonz EduPonz added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Jul 9, 2024
@richiware richiware merged commit 67eefa2 into master Jul 9, 2024
27 of 31 checks passed
@richiware richiware deleted the feature/21222 branch July 9, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants