Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21397] Parse IDL string for xtypes #4943

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

[21397] Parse IDL string for xtypes #4943

wants to merge 24 commits into from

Conversation

YangboLong
Copy link
Contributor

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@EduPonz EduPonz added this to the v3.0.0 milestone Jun 21, 2024
@elianalf elianalf added needs-review PR that is ready to be reviewed to-do labels Jun 24, 2024
@EduPonz EduPonz modified the milestones: v3.0.0, v3.0.1 Jul 19, 2024
@juanlofer-eprosima juanlofer-eprosima changed the title Parse IDL string for xtypes [21397] Parse IDL string for xtypes Jul 22, 2024
@juanlofer-eprosima juanlofer-eprosima modified the milestones: v3.0.1, v3.0.0 Jul 22, 2024
richiware
richiware requested changes Jul 26, 2024
View reviewed changes
src/cpp/fastdds/xtypes/dynamic_types/idl_parser/IdlParser.hpp Outdated Show resolved Hide resolved
src/cpp/fastdds/xtypes/dynamic_types/idl_parser/IdlParser.hpp Outdated Show resolved Hide resolved
src/cpp/fastdds/xtypes/dynamic_types/idl_parser/IdlParser.hpp Outdated Show resolved Hide resolved
examples/cpp/dds/IdlParserExample/IdlParser_main.cpp Outdated Show resolved Hide resolved
include/fastdds/dds/xtypes/dynamic_types/DynamicTypeBuilderFactory.hpp Outdated Show resolved Hide resolved
src/cpp/fastdds/xtypes/dynamic_types/idl_parser/IdlParser.hpp Outdated Show resolved Hide resolved
src/cpp/fastdds/xtypes/dynamic_types/idl_parser/IdlParser.hpp Outdated Show resolved Hide resolved
src/cpp/fastdds/xtypes/dynamic_types/idl_parser/IdlParser.hpp Outdated Show resolved Hide resolved
src/cpp/fastdds/xtypes/dynamic_types/idl_parser/IdlParser.hpp Outdated Show resolved Hide resolved
src/cpp/fastdds/xtypes/dynamic_types/idl_parser/IdlParser.hpp Outdated Show resolved Hide resolved
@richiware
Copy link
Member

Review current state. Next should be the testing.

@rsanchez15 rsanchez15 modified the milestones: v3.0.1, v3.1.0 Sep 4, 2024
@rsanchez15 rsanchez15 modified the milestones: v3.1.0, v3.2.0 Oct 3, 2024
@YangboLong
Implement idl parser (in progress)
3f13f8a 
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
@YangboLong
Adapt literals and expressions parsing to new xtype APIs
e6c25e5 
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
@YangboLong
Compile code in Windows
f02c44e 
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
@YangboLong
Fix alias parsing
6718735 
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
@YangboLong
Fix code to run through example in Linux
7027ee8 
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
@YangboLong
Fix format and compile warnings
e611e00 
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
@YangboLong
Fix type for parsing integer literals
eec4d6e 
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
@YangboLong
Fix union default label parsing
e02b580 
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
@YangboLong
Support create_type_w_document
10d8644 
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
@YangboLong
Remove example
09db307 
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
@YangboLong
Capture exceptions before return to user code
733f6a7 
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
@YangboLong
Implement get_temporary_file
a548593 
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
@YangboLong
Build with EPROSIMA_BUILD_TESTS=ON
bf7a913 
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
@YangboLong
Add unit tests
156e2f7 
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
@YangboLong
Build and run tests on Linux
fee563d 
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
@YangboLong
Parse basic_inner_types.idl
ecf902b 
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
@YangboLong
Parse structures.idl (in progress)
76d3f4e 
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
@YangboLong
Fix struct member type/name parsing and const parsing
3266ce6 
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
@YangboLong
Fix struct parsing when struct members have arrays
311dd2e 
Example input:
struct StructMixedArray
{
    short var_short;
    int32 var_array[10];
    float var_multi_array[5][15];
};

Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
@YangboLong
Skip sequence and map parsing
4302d64 
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
@YangboLong
Test structures.idl with proper comments
324c70c 
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
@YangboLong
Test alases.idl
eea1733 
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
@YangboLong
Try fixing ci/cd
0c5855a 
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
@YangboLong
Fix struct parsing with member being array
47d848b 
Handle the case when array size being an identifier instead of integer.
For example:

const long size_1 = 5;
struct ArraySingleDimensionLiteralsShort
{
    short var_array_short[size_1];
};

Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richiware richiware Awaiting requested review from richiware

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
needs-review PR that is ready to be reviewed to-do
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
6 participants
@YangboLong @richiware @EduPonz @rsanchez15 @elianalf @juanlofer-eprosima