[20815] Only apply content filter to ALIVE changes #4876

EduPonz · 2024-05-30T13:06:00Z

Description

Backport of #4835 to 2.x

This PR fixes a bug that caused the content filter to also be applied to unregister and disposed samples. Since in those messages the only fields populated (if any) are the ones annotated with @key, the unregister and dispose samples did not pass the filter (in general) and thus were being discarded. This caused several issues:

When writing to more than 10 instances with default Qos (keep last 1, max_instances 10), only the first 10 samples were been received.
In best effort, when setting the history depth and max instances appropriately, all samples were received, but calls to unregister or dispose followed by a write were triggering sample_lost events, as the received sequence numbers were not consecutive (because of the filtering out of the unregister/dispose).

This PR fixes these issues by only querying for sample relevance when the CacheChange kind is ALIVE.

@Mergifyio backport 2.13.x 2.10.x 2.6.x

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
Any new/modified methods have been properly documented using Doxygen.
N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A: New feature has been added to the versions.md file (if applicable).
N/A: New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

test/blackbox/api/dds-pim/PubSubReader.hpp

include/fastrtps/types/DynamicPubSubType.h

Mario-DL

Just leaving some minor suggestions

test/blackbox/common/DDSBlackboxTestsContentFilter.cpp

Mario-DL

LGTM with green CI

EduPonz · 2024-06-04T14:23:10Z

@Mergifyio backport 2.13.x 2.10.x 2.6.x

mergify · 2024-06-04T14:23:18Z

backport 2.13.x 2.10.x 2.6.x

✅ Backports have been created

#4902 [20815] Only apply content filter to ALIVE changes (backport #4876) has been created for branch 2.13.x but encountered conflicts
#4903 [20815] Only apply content filter to ALIVE changes (backport #4876) has been created for branch 2.10.x but encountered conflicts
#4904 [20815] Only apply content filter to ALIVE changes (backport #4876) has been created for branch 2.6.x but encountered conflicts

EduPonz · 2024-06-04T14:23:25Z

@richiprosima please test this

include/fastrtps/types/DynamicLoanableSequence.hpp

test/blackbox/api/dds-pim/PubSubTypeTraits.hpp

EduPonz · 2024-06-05T06:56:49Z

@richiprosima please test discovery-server

include/fastrtps/types/DynamicLoanableSequence.hpp

EduPonz · 2024-06-05T08:01:23Z

@richiprosima please test discovery-server

MiguelCompany

LGTM with green CI

test/blackbox/api/dds-pim/PubSubReader.hpp

Signed-off-by: eduponz <eduardoponz@eprosima.com>

…field Signed-off-by: eduponz <eduardoponz@eprosima.com>

Signed-off-by: eduponz <eduardoponz@eprosima.com>

EduPonz · 2024-06-05T10:25:22Z

@richiprosima please test discovery-server

Mario-DL

LGTM with green CI !
Nice work here 👏🏻

* Refs #20815: Add regression test Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Only apply filter to ALIVE changes Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Rename change_is_relevant_for_filter argument Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Refactor test Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Cast loop index to uint16_t for assigning it to the key field Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Refactor test so PubSubWriter can be used directly Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Fix memory leak Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Apply Mario's suggestions Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Add type traits to PubSubWriterReader and PubSubParticipant Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Default move ctor and assignment in DynamicLoanableSequence Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Add doxygen in DynamicLoanableSequence Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Delete copy semantic from DynamicLoanableSequence Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Use alias for TypeTraits::DataListType in PubSub* classes Signed-off-by: eduponz <eduardoponz@eprosima.com> --------- Signed-off-by: eduponz <eduardoponz@eprosima.com> (cherry picked from commit 9a64956) # Conflicts: # src/cpp/rtps/reader/StatefulReader.cpp # src/cpp/rtps/reader/StatelessReader.cpp # test/unittest/statistics/dds/CMakeLists.txt

* Refs #20815: Add regression test Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Only apply filter to ALIVE changes Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Rename change_is_relevant_for_filter argument Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Refactor test Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Cast loop index to uint16_t for assigning it to the key field Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Refactor test so PubSubWriter can be used directly Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Fix memory leak Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Apply Mario's suggestions Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Add type traits to PubSubWriterReader and PubSubParticipant Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Default move ctor and assignment in DynamicLoanableSequence Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Add doxygen in DynamicLoanableSequence Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Delete copy semantic from DynamicLoanableSequence Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Use alias for TypeTraits::DataListType in PubSub* classes Signed-off-by: eduponz <eduardoponz@eprosima.com> --------- Signed-off-by: eduponz <eduardoponz@eprosima.com> (cherry picked from commit 9a64956) # Conflicts: # src/cpp/rtps/reader/StatefulReader.cpp # src/cpp/rtps/reader/StatelessReader.cpp # test/blackbox/api/dds-pim/PubSubReader.hpp # test/blackbox/api/dds-pim/PubSubWriter.hpp # test/unittest/dds/publisher/CMakeLists.txt # test/unittest/statistics/dds/CMakeLists.txt

* Refs #20815: Add regression test Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Only apply filter to ALIVE changes Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Rename change_is_relevant_for_filter argument Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Refactor test Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Cast loop index to uint16_t for assigning it to the key field Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Refactor test so PubSubWriter can be used directly Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Fix memory leak Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Apply Mario's suggestions Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Add type traits to PubSubWriterReader and PubSubParticipant Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Default move ctor and assignment in DynamicLoanableSequence Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Add doxygen in DynamicLoanableSequence Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Delete copy semantic from DynamicLoanableSequence Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Use alias for TypeTraits::DataListType in PubSub* classes Signed-off-by: eduponz <eduardoponz@eprosima.com> --------- Signed-off-by: eduponz <eduardoponz@eprosima.com> (cherry picked from commit 9a64956) Signed-off-by: eduponz <eduardoponz@eprosima.com>

* Refs #20815: Add regression test Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Only apply filter to ALIVE changes Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Rename change_is_relevant_for_filter argument Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Refactor test Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Cast loop index to uint16_t for assigning it to the key field Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Refactor test so PubSubWriter can be used directly Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Fix memory leak Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Apply Mario's suggestions Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Add type traits to PubSubWriterReader and PubSubParticipant Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Default move ctor and assignment in DynamicLoanableSequence Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Add doxygen in DynamicLoanableSequence Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Delete copy semantic from DynamicLoanableSequence Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Use alias for TypeTraits::DataListType in PubSub* classes Signed-off-by: eduponz <eduardoponz@eprosima.com> --------- Signed-off-by: eduponz <eduardoponz@eprosima.com> (cherry picked from commit 9a64956) # Conflicts: # src/cpp/rtps/reader/StatefulReader.cpp # src/cpp/rtps/reader/StatelessReader.cpp # test/unittest/statistics/dds/CMakeLists.txt Signed-off-by: eduponz <eduardoponz@eprosima.com>

* Refs #20815: Add regression test Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Only apply filter to ALIVE changes Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Rename change_is_relevant_for_filter argument Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Refactor test Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Cast loop index to uint16_t for assigning it to the key field Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Refactor test so PubSubWriter can be used directly Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Fix memory leak Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Apply Mario's suggestions Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Add type traits to PubSubWriterReader and PubSubParticipant Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Default move ctor and assignment in DynamicLoanableSequence Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Add doxygen in DynamicLoanableSequence Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Delete copy semantic from DynamicLoanableSequence Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Use alias for TypeTraits::DataListType in PubSub* classes Signed-off-by: eduponz <eduardoponz@eprosima.com> --------- Signed-off-by: eduponz <eduardoponz@eprosima.com> (cherry picked from commit 9a64956) Signed-off-by: eduponz <eduardoponz@eprosima.com>

* [20815] Only apply content filter to ALIVE changes (#4876) * Refs #20815: Add regression test Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Only apply filter to ALIVE changes Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Rename change_is_relevant_for_filter argument Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Refactor test Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Cast loop index to uint16_t for assigning it to the key field Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Refactor test so PubSubWriter can be used directly Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Fix memory leak Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Apply Mario's suggestions Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Add type traits to PubSubWriterReader and PubSubParticipant Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Default move ctor and assignment in DynamicLoanableSequence Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Add doxygen in DynamicLoanableSequence Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Delete copy semantic from DynamicLoanableSequence Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Use alias for TypeTraits::DataListType in PubSub* classes Signed-off-by: eduponz <eduardoponz@eprosima.com> --------- Signed-off-by: eduponz <eduardoponz@eprosima.com> (cherry picked from commit 9a64956) # Conflicts: # src/cpp/rtps/reader/StatefulReader.cpp # src/cpp/rtps/reader/StatelessReader.cpp # test/unittest/statistics/dds/CMakeLists.txt Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Avoid doxygen warning about undocumented param in deleted functions Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Rename some targets to be able to compile with thirdparty Signed-off-by: eduponz <eduardoponz@eprosima.com> --------- Signed-off-by: eduponz <eduardoponz@eprosima.com> Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>

* [20815] Only apply content filter to ALIVE changes (#4876) * Refs #20815: Add regression test Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Only apply filter to ALIVE changes Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Rename change_is_relevant_for_filter argument Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Refactor test Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Cast loop index to uint16_t for assigning it to the key field Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Refactor test so PubSubWriter can be used directly Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Fix memory leak Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Apply Mario's suggestions Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Add type traits to PubSubWriterReader and PubSubParticipant Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Default move ctor and assignment in DynamicLoanableSequence Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Add doxygen in DynamicLoanableSequence Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Delete copy semantic from DynamicLoanableSequence Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Use alias for TypeTraits::DataListType in PubSub* classes Signed-off-by: eduponz <eduardoponz@eprosima.com> --------- Signed-off-by: eduponz <eduardoponz@eprosima.com> (cherry picked from commit 9a64956) Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Avoid doxygen warning about undocumented param in deleted functions Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Rename some targets to be able to compile with thirdparty Signed-off-by: eduponz <eduardoponz@eprosima.com> --------- Signed-off-by: eduponz <eduardoponz@eprosima.com> Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>

* Refs #20815: Add regression test Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Only apply filter to ALIVE changes Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Rename change_is_relevant_for_filter argument Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Refactor test Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Cast loop index to uint16_t for assigning it to the key field Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Refactor test so PubSubWriter can be used directly Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Fix memory leak Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Apply Mario's suggestions Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Add type traits to PubSubWriterReader and PubSubParticipant Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Default move ctor and assignment in DynamicLoanableSequence Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Add doxygen in DynamicLoanableSequence Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Delete copy semantic from DynamicLoanableSequence Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Use alias for TypeTraits::DataListType in PubSub* classes Signed-off-by: eduponz <eduardoponz@eprosima.com> --------- Signed-off-by: eduponz <eduardoponz@eprosima.com> (cherry picked from commit 9a64956) Signed-off-by: eduponz <eduardoponz@eprosima.com>

* [20815] Only apply content filter to ALIVE changes (#4876) * Refs #20815: Add regression test Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Only apply filter to ALIVE changes Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Rename change_is_relevant_for_filter argument Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Refactor test Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Cast loop index to uint16_t for assigning it to the key field Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Refactor test so PubSubWriter can be used directly Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Fix memory leak Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Apply Mario's suggestions Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Add type traits to PubSubWriterReader and PubSubParticipant Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Default move ctor and assignment in DynamicLoanableSequence Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Add doxygen in DynamicLoanableSequence Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Delete copy semantic from DynamicLoanableSequence Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Use alias for TypeTraits::DataListType in PubSub* classes Signed-off-by: eduponz <eduardoponz@eprosima.com> --------- Signed-off-by: eduponz <eduardoponz@eprosima.com> (cherry picked from commit 9a64956) Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Avoid doxygen warning about undocumented param in deleted functions Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20815: Rename some targets to be able to compile with thirdparty Signed-off-by: eduponz <eduardoponz@eprosima.com> --------- Signed-off-by: eduponz <eduardoponz@eprosima.com> Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>

EduPonz added this to the v2.14.2 milestone May 30, 2024

EduPonz requested a review from Mario-DL May 30, 2024 13:06

github-actions bot added ci-pending PR which CI is running labels May 30, 2024

EduPonz mentioned this pull request May 30, 2024

[20815] Only apply content filter to ALIVE changes #4835

Merged

12 tasks

MiguelCompany requested changes May 30, 2024

View reviewed changes

test/blackbox/api/dds-pim/PubSubReader.hpp Outdated Show resolved Hide resolved

include/fastrtps/types/DynamicPubSubType.h Outdated Show resolved Hide resolved

EduPonz requested review from MiguelCompany and removed request for MiguelCompany May 31, 2024 09:06

Mario-DL requested changes Jun 3, 2024

View reviewed changes

test/blackbox/common/DDSBlackboxTestsContentFilter.cpp Outdated Show resolved Hide resolved

test/blackbox/common/DDSBlackboxTestsContentFilter.cpp Outdated Show resolved Hide resolved

test/blackbox/common/DDSBlackboxTestsContentFilter.cpp Outdated Show resolved Hide resolved

Mario-DL self-requested a review June 4, 2024 06:04

Mario-DL previously approved these changes Jun 4, 2024

View reviewed changes

MiguelCompany requested changes Jun 4, 2024

View reviewed changes

include/fastrtps/types/DynamicLoanableSequence.hpp Show resolved Hide resolved

include/fastrtps/types/DynamicLoanableSequence.hpp Show resolved Hide resolved

test/blackbox/api/dds-pim/PubSubTypeTraits.hpp Show resolved Hide resolved

EduPonz dismissed Mario-DL’s stale review via 344c935 June 5, 2024 06:54

EduPonz requested review from MiguelCompany and Mario-DL June 5, 2024 06:55

MiguelCompany requested changes Jun 5, 2024

View reviewed changes

include/fastrtps/types/DynamicLoanableSequence.hpp Outdated Show resolved Hide resolved

EduPonz requested a review from MiguelCompany June 5, 2024 08:01

MiguelCompany previously approved these changes Jun 5, 2024

View reviewed changes

Mario-DL reviewed Jun 5, 2024

View reviewed changes

test/blackbox/api/dds-pim/PubSubReader.hpp Outdated Show resolved Hide resolved

EduPonz added 5 commits June 5, 2024 12:12

Refs #20815: Add regression test

bfd054d

Signed-off-by: eduponz <eduardoponz@eprosima.com>

Refs #20815: Only apply filter to ALIVE changes

d2ff315

Signed-off-by: eduponz <eduardoponz@eprosima.com>

Refs #20815: Rename change_is_relevant_for_filter argument

1320ea7

Signed-off-by: eduponz <eduardoponz@eprosima.com>

Refs #20815: Refactor test

a8f6488

Signed-off-by: eduponz <eduardoponz@eprosima.com>

Refs #20815: Cast loop index to uint16_t for assigning it to the key …

d0fc6ed

…field Signed-off-by: eduponz <eduardoponz@eprosima.com>

EduPonz added 3 commits June 5, 2024 12:12

Refs #20815: Add doxygen in DynamicLoanableSequence

ddd9d73

Signed-off-by: eduponz <eduardoponz@eprosima.com>

Refs #20815: Delete copy semantic from DynamicLoanableSequence

1e196dc

Signed-off-by: eduponz <eduardoponz@eprosima.com>

Refs #20815: Use alias for TypeTraits::DataListType in PubSub* classes

f1a5840

Signed-off-by: eduponz <eduardoponz@eprosima.com>

EduPonz dismissed MiguelCompany’s stale review via f1a5840 June 5, 2024 10:24

EduPonz force-pushed the bugfix/2.14.x/only_filter_alive_changes branch from 0164529 to f1a5840 Compare June 5, 2024 10:24

EduPonz requested review from Mario-DL and MiguelCompany June 5, 2024 10:25

Mario-DL approved these changes Jun 5, 2024

View reviewed changes

MiguelCompany approved these changes Jun 5, 2024

View reviewed changes

EduPonz added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jun 6, 2024

EduPonz merged commit 9a64956 into 2.14.x Jun 6, 2024
11 of 14 checks passed

EduPonz deleted the bugfix/2.14.x/only_filter_alive_changes branch June 6, 2024 10:47

mergify bot mentioned this pull request Jun 6, 2024

[20815] Only apply content filter to ALIVE changes (backport #4876) #4902

Merged

12 tasks

This was referenced Jun 6, 2024

[20815] Only apply content filter to ALIVE changes (backport #4876) #4903

Merged

[20815] Only apply content filter to ALIVE changes (backport #4876) #4904

Merged

EduPonz mentioned this pull request Jun 8, 2024

[20815] Fix doxygen warning about undocumented param in deleted functions #4918

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[20815] Only apply content filter to ALIVE changes #4876

[20815] Only apply content filter to ALIVE changes #4876

EduPonz commented May 30, 2024 •

edited

Loading

Mario-DL left a comment

Mario-DL left a comment

EduPonz commented Jun 4, 2024

mergify bot commented Jun 4, 2024 •

edited

Loading

EduPonz commented Jun 4, 2024

EduPonz commented Jun 5, 2024

EduPonz commented Jun 5, 2024

MiguelCompany left a comment

EduPonz commented Jun 5, 2024

Mario-DL left a comment

[20815] Only apply content filter to ALIVE changes #4876

[20815] Only apply content filter to ALIVE changes #4876

Conversation

EduPonz commented May 30, 2024 • edited Loading

Description

Contributor Checklist

Reviewer Checklist

Mario-DL left a comment

Choose a reason for hiding this comment

Mario-DL left a comment

Choose a reason for hiding this comment

EduPonz commented Jun 4, 2024

mergify bot commented Jun 4, 2024 • edited Loading

✅ Backports have been created

EduPonz commented Jun 4, 2024

EduPonz commented Jun 5, 2024

EduPonz commented Jun 5, 2024

MiguelCompany left a comment

Choose a reason for hiding this comment

EduPonz commented Jun 5, 2024

Mario-DL left a comment

Choose a reason for hiding this comment

EduPonz commented May 30, 2024 •

edited

Loading

mergify bot commented Jun 4, 2024 •

edited

Loading