Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20707] Migrate BuiltinEndpoints defines to variables #4851

Merged
merged 8 commits into from
Jun 3, 2024
Merged

[20707] Migrate BuiltinEndpoints defines to variables #4851

merged 8 commits into from
Jun 3, 2024

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented May 27, 2024 •
edited by elianalf
Loading

Description

This PR migrates the #defines in BuiltinEndpoints to namespaced constextpr .

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A; Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • ❌ Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • ❌ Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A; Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@EduPonz EduPonz added this to the v3.0.0 milestone May 27, 2024
@EduPonz EduPonz mentioned this pull request May 27, 2024
Merged
6 tasks
@elianalf elianalf changed the title [20707] Migrate BuiltinEndpoints [20707] Migrate BuiltinEndpoints defines to variables May 28, 2024
@elianalf elianalf added the needs-review PR that is ready to be reviewed label May 28, 2024
@elianalf elianalf removed the needs-review PR that is ready to be reviewed label May 30, 2024
@EduPonz EduPonz force-pushed the feature/migrate_builtin_endpoints branch from 9ed4046 to d3116b6 Compare May 30, 2024 13:01
@EduPonz EduPonz requested a review from elianalf May 30, 2024 13:01
@github-actions github-actions bot added the ci-pending PR which CI is running label May 30, 2024
@EduPonz EduPonz requested review from elianalf and removed request for elianalf May 30, 2024 13:09
@EduPonz EduPonz force-pushed the feature/migrate_builtin_endpoints branch from 2699df2 to 633a43f Compare May 31, 2024 09:13
@EduPonz EduPonz requested a review from elianalf May 31, 2024 09:13
@EduPonz
Refs #20707: Migrate BuiltinEndpoints defines to namespaced constexpr
f0ea53f 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #20707: Make private additional constants
8401bf0 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #20707: Update versions.md
7510072 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #20707: Apply Eliana's suggestions
1eb4dc4 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #20707: Rename ParticipantProxyData.h to ParticipantProxyData.hpp
26f3d65 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #20707: Uncrustify
d68b308 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #20707: Exclude MockAccessControlPlugin.h from uncrustify
78580ce 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #20707: Fix uncrustify issue in ParticipantDiscoveryInfo.h
8314ebb 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz EduPonz added the skip-ci Automatically pass CI label Jun 3, 2024
@EduPonz EduPonz force-pushed the feature/migrate_builtin_endpoints branch from 633a43f to 8314ebb Compare June 3, 2024 05:48
@EduPonz EduPonz requested review from elianalf and removed request for elianalf June 3, 2024 05:49
@EduPonz EduPonz merged commit ed046c3 into master Jun 3, 2024
8 checks passed
@EduPonz EduPonz deleted the feature/migrate_builtin_endpoints branch June 3, 2024 05:53
EduPonz added a commit that referenced this pull request Jun 3, 2024
@EduPonz
Migrate BuiltinEndpoints defines to variables (#4851)
b002c1d 
* Refs #20707: Migrate BuiltinEndpoints defines to namespaced constexpr

Signed-off-by: eduponz <eduardoponz@eprosima.com>

* Refs #20707: Make private additional constants

Signed-off-by: eduponz <eduardoponz@eprosima.com>

* Refs #20707: Update versions.md

Signed-off-by: eduponz <eduardoponz@eprosima.com>

* Refs #20707: Apply Eliana's suggestions

Signed-off-by: eduponz <eduardoponz@eprosima.com>

* Refs #20707: Rename ParticipantProxyData.h to ParticipantProxyData.hpp

Signed-off-by: eduponz <eduardoponz@eprosima.com>

* Refs #20707: Uncrustify

Signed-off-by: eduponz <eduardoponz@eprosima.com>

* Refs #20707: Exclude MockAccessControlPlugin.h from uncrustify

Signed-off-by: eduponz <eduardoponz@eprosima.com>

* Refs #20707: Fix uncrustify issue in ParticipantDiscoveryInfo.h

Signed-off-by: eduponz <eduardoponz@eprosima.com>

---------

Signed-off-by: eduponz <eduardoponz@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elianalf elianalf elianalf approved these changes

Assignees
No one assigned
Labels
ci-pending PR which CI is running skip-ci Automatically pass CI
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@EduPonz @elianalf