Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21051] DynamicType to IDL serializer #4787

Merged
merged 52 commits into from
Jul 12, 2024
Merged

[21051] DynamicType to IDL serializer #4787

merged 52 commits into from
Jul 12, 2024

Conversation

juanlofer-eprosima
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima commented May 14, 2024 •
edited by Tempate
Loading

Description

This PR implements functionality to serialize a DynamicType to IDL.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
    [21051] Documentation to serialize DynamicTypes to IDL Fast-DDS-docs#865
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

juanlofer-eprosima
juanlofer-eprosima commented May 14, 2024
View reviewed changes
src/cpp/utils/collections/Tree.hpp Outdated Show resolved Hide resolved
include/fastdds/dds/xtypes/utils.hpp Outdated Show resolved Hide resolved
include/fastdds/dds/xtypes/utils.hpp Outdated Show resolved Hide resolved
src/cpp/fastdds/xtypes/utils.cpp Outdated Show resolved Hide resolved
src/cpp/fastdds/xtypes/utils.cpp Outdated Show resolved Hide resolved
src/cpp/fastdds/xtypes/utils.cpp Outdated Show resolved Hide resolved
src/cpp/fastdds/xtypes/utils.cpp Outdated Show resolved Hide resolved
src/cpp/fastdds/xtypes/utils.cpp Outdated Show resolved Hide resolved
src/cpp/fastdds/xtypes/utils.cpp Outdated Show resolved Hide resolved
src/cpp/fastdds/xtypes/utils.cpp Outdated Show resolved Hide resolved
@juanlofer-eprosima juanlofer-eprosima added this to the v3.0.0 milestone May 14, 2024
@juanlofer-eprosima juanlofer-eprosima changed the title DynamicType to IDL serializer [21051] DynamicType to IDL serializer May 20, 2024
@juanlofer-eprosima
Copy link
Contributor Author

Consider extending conversions to take annotations into account.

@elianalf elianalf added needs-review PR that is ready to be reviewed to-do labels May 30, 2024
@Tempate Tempate mentioned this pull request Jun 4, 2024
Merged
@Tempate
Copy link
Contributor

Tempate commented Jun 20, 2024

@richiprosima please test_3 this

@Tempate Tempate mentioned this pull request Jun 21, 2024
Closed
7 tasks
@elianalf elianalf added ci-pending PR which CI is running and removed needs-review PR that is ready to be reviewed to-do labels Jun 24, 2024
juanlofer-eprosima
juanlofer-eprosima commented Jul 3, 2024
View reviewed changes
include/fastdds/dds/xtypes/utils.hpp Outdated Show resolved Hide resolved
include/fastdds/dds/xtypes/utils.hpp Outdated Show resolved Hide resolved
include/fastdds/dds/xtypes/utils.hpp Outdated Show resolved Hide resolved
include/fastdds/dds/xtypes/utils.hpp Outdated Show resolved Hide resolved
src/cpp/fastdds/xtypes/type_conversion/dyn_type_tree.hpp Outdated Show resolved Hide resolved
src/cpp/fastdds/xtypes/type_conversion/dyn_type_tree.ipp Outdated Show resolved Hide resolved
src/cpp/fastdds/xtypes/type_conversion/dyn_type_tree.ipp Outdated Show resolved Hide resolved
src/cpp/fastdds/xtypes/type_conversion/dyn_type_tree.ipp Outdated Show resolved Hide resolved
src/cpp/fastdds/xtypes/type_conversion/dyn_type_tree.ipp Outdated Show resolved Hide resolved
src/cpp/fastdds/xtypes/type_conversion/dyn_type_tree.ipp Outdated Show resolved Hide resolved
juanlofer-eprosima
juanlofer-eprosima commented Jul 4, 2024
View reviewed changes
test/unittest/dds/xtypes/type_conversion/types/idls/inheritance_struct.idl Outdated Show resolved Hide resolved
test/unittest/dds/xtypes/type_conversion/types/all_types.hpp Outdated Show resolved Hide resolved
test/unittest/dds/xtypes/type_conversion/types/type_objects/alias_struct/alias_struct.hpp Outdated Show resolved Hide resolved
test/unittest/dds/xtypes/type_conversion/DynamicTypeSerializationTests.cpp Outdated Show resolved Hide resolved
test/unittest/dds/xtypes/type_conversion/types/idls/arrays_and_sequences.idl Outdated Show resolved Hide resolved
src/cpp/fastdds/xtypes/type_conversion/dyn_type_tree.ipp Outdated Show resolved Hide resolved
src/cpp/fastdds/xtypes/type_conversion/dyn_type_tree.ipp Outdated Show resolved Hide resolved
src/cpp/fastdds/xtypes/type_conversion/dyn_type_tree.ipp Outdated Show resolved Hide resolved
src/cpp/fastdds/xtypes/type_conversion/dyn_type_tree.ipp Outdated Show resolved Hide resolved
src/cpp/fastdds/xtypes/type_conversion/dyn_type_tree.ipp Outdated Show resolved Hide resolved
@juanlofer-eprosima
Copy link
Contributor Author

Add the new IDL files to update_generated_code_from_idl.sh.

@juanlofer-eprosima
Copy link
Contributor Author

Add the new IDL files to update_generated_code_from_idl.sh.

By appending the following to files_needing_output_dir

'./test/unittest/dds/xtypes/serializers/idl/types/alias_struct/alias_struct.idl|./gen'
'./test/unittest/dds/xtypes/serializers/idl/types/array_struct/array_struct.idl|./gen'
'./test/unittest/dds/xtypes/serializers/idl/types/bitmask_struct/bitmask_struct.idl|./gen'
'./test/unittest/dds/xtypes/serializers/idl/types/bitset_struct/bitset_struct.idl|./gen'
'./test/unittest/dds/xtypes/serializers/idl/types/enum_struct/enum_struct.idl|./gen'
'./test/unittest/dds/xtypes/serializers/idl/types/extensibility_struct/extensibility_struct.idl|./gen'
'./test/unittest/dds/xtypes/serializers/idl/types/key_struct/key_struct.idl|./gen'
'./test/unittest/dds/xtypes/serializers/idl/types/map_struct/map_struct.idl|./gen'
'./test/unittest/dds/xtypes/serializers/idl/types/primitives_struct/primitives_struct.idl|./gen'
'./test/unittest/dds/xtypes/serializers/idl/types/sequence_struct/sequence_struct.idl|./gen'
'./test/unittest/dds/xtypes/serializers/idl/types/string_struct/string_struct.idl|./gen'
'./test/unittest/dds/xtypes/serializers/idl/types/struct_struct/struct_struct.idl|./gen'
'./test/unittest/dds/xtypes/serializers/idl/types/union_struct/union_struct.idl|./gen'

@Tempate
Review - Apply suggestions
890c285 
Signed-off-by: tempate <danieldiaz@eprosima.com>
@Tempate
Review - Apply JSON suggestions
8419c84 
Signed-off-by: tempate <danieldiaz@eprosima.com>
@Tempate
Uncrustify
0626d71 
Signed-off-by: tempate <danieldiaz@eprosima.com>
@Tempate Tempate requested review from richiprosima and removed request for richiprosima July 11, 2024 07:23
@Tempate
Review - Apply suggestions
1e866de 
Signed-off-by: tempate <danieldiaz@eprosima.com>
@Tempate Tempate removed the request for review from richiprosima July 11, 2024 07:43
juanlofer-eprosima
juanlofer-eprosima commented Jul 11, 2024
View reviewed changes
Copy link
Contributor Author

@juanlofer-eprosima juanlofer-eprosima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tempate Tempate mentioned this pull request Jul 11, 2024
Merged
7 tasks
@Tempate
Fix - default_type_kind may be used uninitialized
d82da58 
Signed-off-by: tempate <danieldiaz@eprosima.com>
@Tempate Tempate requested review from richiprosima and removed request for richiprosima July 11, 2024 08:43
Tempate
Tempate previously approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@Tempate Tempate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

richiware
richiware previously approved these changes Jul 11, 2024
View reviewed changes
@Tempate Tempate dismissed stale reviews from richiware and themself via 568668d July 11, 2024 15:01
@Tempate Tempate requested review from richiprosima and removed request for richiprosima July 11, 2024 15:02
@Tempate
Fix - signed/unsigned mismatch
d3842f4 
Signed-off-by: tempate <danieldiaz@eprosima.com>
@Tempate Tempate requested review from richiprosima and removed request for richiprosima July 11, 2024 19:24
Tempate
Tempate approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@Tempate Tempate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EduPonz EduPonz merged commit bc67cf7 into master Jul 12, 2024
15 of 17 checks passed
@EduPonz EduPonz deleted the feature/dynamic-type-idl branch July 12, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz left review comments

@Tempate Tempate Tempate approved these changes

@richiware richiware richiware left review comments

@richiprosima richiprosima Awaiting requested review from richiprosima

Assignees
No one assigned
Labels
ci-pending PR which CI is running
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@juanlofer-eprosima @Tempate @richiware @EduPonz @elianalf