Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20994] Consider library behavior changes as ABI breaks in the PR template checklist #4775

Merged
merged 1 commit into from
May 14, 2024
Merged

[20994] Consider library behavior changes as ABI breaks in the PR template checklist #4775

merged 1 commit into from
May 14, 2024

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented May 13, 2024 •
edited by EduPonz
Loading

Description

This PR updates the pull request template to take into consideration possible library core behavior changes, and consider them as in the same level as ABI breaks.

@Mergifyio backport 2.14.x 2.13.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso JesusPoderoso added this to the v2.14.2 milestone May 13, 2024
@JesusPoderoso JesusPoderoso added the skip-ci Automatically pass CI label May 13, 2024
@JesusPoderoso
Copy link
Contributor Author

@richiprosima please test this

@JesusPoderoso JesusPoderoso changed the title [20994] Consider library bahavour changes as ABI breaks in the PR template checklist [20994] Consider library behavior changes as ABI breaks in the PR template checklist May 13, 2024
EduPonz
EduPonz previously approved these changes May 13, 2024
View reviewed changes
@EduPonz
Copy link

EduPonz commented May 13, 2024

@JesusPoderoso please rebase on 3.0.x-devel and update the backport list

@JesusPoderoso JesusPoderoso modified the milestones: v2.14.2, v3.0.0 May 13, 2024
@JesusPoderoso
Refs #20994: Update PR template with ABI & behaviour changes nuances
f237eca 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso JesusPoderoso changed the base branch from master to 3.0.x-devel May 13, 2024 14:02
EduPonz
EduPonz previously approved these changes May 13, 2024
View reviewed changes
@EduPonz EduPonz deleted the branch master May 14, 2024 07:22
@EduPonz EduPonz closed this May 14, 2024
@EduPonz EduPonz reopened this May 14, 2024
@EduPonz EduPonz changed the base branch from 3.0.x-devel to master May 14, 2024 07:25
@EduPonz EduPonz dismissed their stale review May 14, 2024 07:25

The base branch was changed.

@JesusPoderoso
Copy link
Contributor Author

@richiprosima please test this

@JesusPoderoso JesusPoderoso added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label May 14, 2024
@EduPonz
Copy link

EduPonz commented May 14, 2024

@Mergifyio backport 2.14.x 2.13.x 2.10.x 2.6.x

@mergify Mergify
Copy link
Contributor

mergify bot commented May 14, 2024 •
edited
Loading

backport 2.14.x 2.13.x 2.10.x 2.6.x

✅ Backports have been created

@EduPonz EduPonz merged commit 5d1ecac into master May 14, 2024
7 of 8 checks passed
@EduPonz EduPonz deleted the hotfix/20994 branch May 14, 2024 08:00
mergify bot pushed a commit that referenced this pull request May 14, 2024
@JesusPoderoso @mergify
Consider library behavior changes as ABI breaks in the PR template ch…
eed9e3b 
…ecklist (#4775)

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
(cherry picked from commit 5d1ecac)
mergify bot pushed a commit that referenced this pull request May 14, 2024
@JesusPoderoso @mergify
Consider library behavior changes as ABI breaks in the PR template ch…
309413d 
…ecklist (#4775)

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
(cherry picked from commit 5d1ecac)
mergify bot pushed a commit that referenced this pull request May 14, 2024
@JesusPoderoso @mergify
Consider library behavior changes as ABI breaks in the PR template ch…
3f34b8d 
…ecklist (#4775)

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
(cherry picked from commit 5d1ecac)
This was referenced May 14, 2024
Merged
Merged
Merged
mergify bot pushed a commit that referenced this pull request May 14, 2024
@JesusPoderoso @mergify
Consider library behavior changes as ABI breaks in the PR template ch…
8e7bb4e 
…ecklist (#4775)

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
(cherry picked from commit 5d1ecac)
@mergify mergify bot mentioned this pull request May 14, 2024
Merged
7 tasks
MiguelCompany pushed a commit that referenced this pull request May 14, 2024
@mergify @JesusPoderoso
Consider library behavior changes as ABI breaks in the PR template ch…
2c0e715 
…ecklist (#4775) (#4783)

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
(cherry picked from commit 5d1ecac)

Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com>
MiguelCompany pushed a commit that referenced this pull request May 14, 2024
@mergify @JesusPoderoso
Consider library behavior changes as ABI breaks in the PR template ch…
57ddaf4 
…ecklist (#4775) (#4782)

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
(cherry picked from commit 5d1ecac)

Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com>
EduPonz pushed a commit that referenced this pull request May 16, 2024
@mergify @JesusPoderoso
Consider library behavior changes as ABI breaks in the PR template ch…
32220cc 
…ecklist (#4775) (#4781)

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
(cherry picked from commit 5d1ecac)

Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com>
EduPonz pushed a commit that referenced this pull request May 16, 2024
@mergify @JesusPoderoso
Consider library behavior changes as ABI breaks in the PR template ch…
d9c275f 
…ecklist (#4775) (#4784)

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
(cherry picked from commit 5d1ecac)

Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. skip-ci Automatically pass CI
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@JesusPoderoso @EduPonz