Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20603] Remove idl parser from .repos file #4535

Merged
merged 1 commit into from
Mar 9, 2024
Merged

[20603] Remove idl parser from .repos file #4535

merged 1 commit into from
Mar 9, 2024

Conversation

elianalf
Copy link
Contributor

@elianalf elianalf commented Mar 8, 2024 •
edited by EduPonz
Loading

Description

This PR removes idl parser from .repos file, since it's downloaded when gradle fastddsgen.

@Mergifyio backport 2.13.x 2.12.x 2.10.x 2.6.x

Contributor Checklist

  • N/A Commit messages follow the project guidelines.
  • N/A The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Changes are ABI compatible.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@elianalf
Refs #20603: Remove idl parser from .repos file
ce58773 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf elianalf added the no-test Skip CI tests if PR marked with this label label Mar 8, 2024
@elianalf elianalf added this to the v2.14.0 - Frozen milestone Mar 8, 2024
@elianalf elianalf changed the title Remove idl parser from .repos file [20603] Remove idl parser from .repos file Mar 8, 2024
@EduPonz
Copy link

EduPonz commented Mar 9, 2024

@Mergifyio backport 2.13.x 2.12.x 2.10.x 2.6.x

@EduPonz EduPonz merged commit 128d238 into master Mar 9, 2024
6 of 10 checks passed
@EduPonz EduPonz deleted the hotfix/upgrade_dependency_branch_master branch March 9, 2024 08:37
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 9, 2024 •
edited
Loading

backport 2.13.x 2.12.x 2.10.x 2.6.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 9, 2024
@elianalf @mergify
Remove idl parser from .repos file (#4535)
48731bb 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
(cherry picked from commit 128d238)

# Conflicts:
#	fastrtps.repos
@mergify mergify bot mentioned this pull request Mar 9, 2024
Closed
mergify bot pushed a commit that referenced this pull request Mar 9, 2024
@elianalf @mergify
Remove idl parser from .repos file (#4535)
182dda4 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
(cherry picked from commit 128d238)

# Conflicts:
#	fastrtps.repos
mergify bot pushed a commit that referenced this pull request Mar 9, 2024
@elianalf @mergify
Remove idl parser from .repos file (#4535)
93f9505 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
(cherry picked from commit 128d238)

# Conflicts:
#	fastrtps.repos
@mergify mergify bot mentioned this pull request Mar 9, 2024
Closed
mergify bot pushed a commit that referenced this pull request Mar 9, 2024
@elianalf @mergify
Remove idl parser from .repos file (#4535)
c381d4f 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
(cherry picked from commit 128d238)

# Conflicts:
#	fastrtps.repos
This was referenced Mar 9, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz approved these changes

Assignees
No one assigned
Labels
no-test Skip CI tests if PR marked with this label
Projects
None yet
Milestone
v2.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@elianalf @EduPonz