Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20022] Restore fastcdr submodule to v1.0.24 #4257

Merged
merged 1 commit into from
Jan 17, 2024
Merged

[20022] Restore fastcdr submodule to v1.0.24 #4257

merged 1 commit into from
Jan 17, 2024

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Jan 17, 2024 •
edited by JesusPoderoso
Loading

Description

#2583 downgraded Fast CDR submodule by mistake, this PR restores it to v1.0.24

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A: The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Changes are ABI compatible.
  • N/A: Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@EduPonz
Refs #20022: Restore Fast CDR submodule to v1.0.24
7ca876a 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz EduPonz added the skip-ci Automatically pass CI label Jan 17, 2024
@EduPonz EduPonz added this to the v2.6.7 milestone Jan 17, 2024
@JesusPoderoso
Copy link
Contributor

@richiprosima please test this

JesusPoderoso
JesusPoderoso approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany MiguelCompany merged commit ed70007 into 2.6.x Jan 17, 2024
11 checks passed
@MiguelCompany MiguelCompany deleted the restore_fastcdr_submodule/2.6.x branch January 17, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusPoderoso JesusPoderoso JesusPoderoso approved these changes

Assignees
No one assigned
Labels
skip-ci Automatically pass CI
Projects
None yet
Milestone
v2.6.7
Development

Successfully merging this pull request may close these issues.
3 participants
@EduPonz @JesusPoderoso @MiguelCompany