Fix StatelessWriter locators filtering [18950] (backport #3655) #3688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://github.com/avatars/in/10562?s=60&v=4){kind=small}
* Refs #18950: Introduce regression test Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #18950: Make test build Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Finalize test Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Add fix Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Uncrustify Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Apply suggestions Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Separate parametrized tests Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Issue test compilation warning Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Make messages_sent an object attribute Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Get rid of messages_sent and use object's locator_filter Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Apply suggestion Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> Co-authored-by: JesusPoderoso <jesuspoderoso@eprosima.com> (cherry picked from commit e7720ca)
11 tasks
MiguelCompany
approved these changes
Jul 11, 2023
|
MAC CI error unrelated |
JesusPoderoso
added
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #3655 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com