Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17671] Add on_incompatible_type to RTPS listeners API #3389

Merged
merged 4 commits into from
Mar 22, 2023
Merged

[17671] Add on_incompatible_type to RTPS listeners API #3389

merged 4 commits into from
Mar 22, 2023

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Mar 17, 2023 •
edited by Mario-DL
Loading

Description

As part of the implementation of on_inconsistent_topic, we need to add a callback to the RTPS listeners to notify of an incompatible type.

Marked as no-test since new functionality is not added.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Changes are NOT ABI compatible.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation. Not applicable since we don't document RTPS layer other than in the API reference
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany added the no-test Skip CI tests if PR marked with this label label Mar 17, 2023
@MiguelCompany MiguelCompany added this to the v2.10.0 milestone Mar 17, 2023
@MiguelCompany MiguelCompany added the needs-review PR that is ready to be reviewed label Mar 17, 2023
Mario-DL
Mario-DL requested changes Mar 22, 2023
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a NIT and a suggestion

include/fastdds/rtps/reader/ReaderListener.h Outdated Show resolved Hide resolved
include/fastdds/rtps/reader/ReaderListener.h Show resolved Hide resolved
MiguelCompany and others added 4 commits March 22, 2023 12:24
@MiguelCompany
Refs #17671. Add on_incompatible_type to rtps::ReaderListener.
b12aa87 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #17671. Add on_incompatible_type to rtps::WriterListener.
72026eb 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #17671. Update versions.md.
131ae70 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany @Mario-DL
Refs #17671. Fix doxydoc typo.
b08e85b 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
@MiguelCompany MiguelCompany force-pushed the feature/inconsistent_topic_status/add-rtps-listener-callbacks branch from 44fdab2 to b08e85b Compare March 22, 2023 11:27
Mario-DL
Mario-DL approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mario-DL Mario-DL added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. no-test Skip CI tests if PR marked with this label ci-pending PR which CI is running and removed needs-review PR that is ready to be reviewed no-test Skip CI tests if PR marked with this label ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. labels Mar 22, 2023
@Mario-DL
Copy link
Member

@richiprosima please test this

@MiguelCompany
Copy link
Member Author

@richiprosima Please test mac

@MiguelCompany MiguelCompany added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Mar 22, 2023
@Mario-DL Mario-DL changed the title [17671] Add on_incompatible_type to RTPS listeners API Add on_incompatible_type to RTPS listeners API Mar 22, 2023
@Mario-DL Mario-DL merged commit 0a43497 into master Mar 22, 2023
@Mario-DL Mario-DL deleted the feature/inconsistent_topic_status/add-rtps-listener-callbacks branch March 22, 2023 13:27
@Mario-DL Mario-DL changed the title Add on_incompatible_type to RTPS listeners API [17671] Add on_incompatible_type to RTPS listeners API Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz left review comments

@JLBuenoLopez JLBuenoLopez JLBuenoLopez left review comments

@Mario-DL Mario-DL Mario-DL approved these changes

Assignees
No one assigned
Labels
no-test Skip CI tests if PR marked with this label ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v2.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@MiguelCompany @Mario-DL @EduPonz @JLBuenoLopez