Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17558] Handle SIGTERM in fast-discovery-server #3364

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Mar 14, 2023

Description

This is a little PR that adds a handling for SIGTERM signal, usually useful in bash scripting contexts using kill

@Mergifyio backport 2.9.x 2.8.x 2.6.x 2.1.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL Mario-DL added the needs-review PR that is ready to be reviewed label Mar 14, 2023
@Mario-DL Mario-DL added this to the v2.10.0 milestone Mar 14, 2023
@Mario-DL Mario-DL added no-test Skip CI tests if PR marked with this label skip-ci Automatically pass CI labels Mar 14, 2023
@EduPonz
Copy link

EduPonz commented Mar 15, 2023

@richiprosima please test windows

@EduPonz EduPonz added ci-pending PR which CI is running and removed skip-ci Automatically pass CI needs-review PR that is ready to be reviewed labels Mar 15, 2023
@EduPonz
Copy link

EduPonz commented Mar 15, 2023

@richiprosima please test windows

@EduPonz
Copy link

EduPonz commented Mar 15, 2023

@Mergifyio backport 2.9.x 2.8.x 2.6.x 2.1.x

@mergify
Copy link
Contributor

mergify bot commented Mar 15, 2023

backport 2.9.x 2.8.x 2.6.x 2.1.x

✅ Backports have been created

@MRicoIE2CS MRicoIE2CS added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Mar 16, 2023
@EduPonz EduPonz merged commit 60fb557 into master Mar 16, 2023
@EduPonz EduPonz deleted the fix/ds_handle_sigterm branch March 16, 2023 14:56
mergify bot pushed a commit that referenced this pull request Mar 16, 2023
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit 60fb557)
mergify bot pushed a commit that referenced this pull request Mar 16, 2023
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit 60fb557)
mergify bot pushed a commit that referenced this pull request Mar 16, 2023
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit 60fb557)
mergify bot pushed a commit that referenced this pull request Mar 16, 2023
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit 60fb557)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-test Skip CI tests if PR marked with this label ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants