Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17350] Removed Boost singleton references from mock #3328

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

jsan-rt
Copy link
Contributor

@jsan-rt jsan-rt commented Feb 25, 2023

Merging #3293 added an ASAN heap-buffer-overflow since Boost singleton references were removed from SharedMemSegment on #3298 but those changes were not propagated to the mock used in the test. This PR fixes that issue.

Description

@Mergifyio backport 2.9.x 2.8.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • [NA] Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • [NA] Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • [NA] New feature has been added to the versions.md file (if applicable).
  • [NA] New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
@jsan-rt jsan-rt added this to the v2.10.0 milestone Feb 25, 2023
@EduPonz EduPonz changed the title Refs #17350: Removed Boost singleton references from mock [17350] Removed Boost singleton references from mock Mar 6, 2023
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mario-DL Mario-DL added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Mar 9, 2023
@EduPonz EduPonz merged commit adce931 into master Mar 13, 2023
@EduPonz EduPonz deleted the hotfix/shm_test_asan_warning branch March 13, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants