-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17267] Added missing mutex to WLP::remove_local_reader #3311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
1 task
Mario-DL
approved these changes
Mar 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Failed tests are not related with the changes
Mario-DL
added
the
ready-to-merge
Ready to be merged. CI and changes have been reviewed and approved.
label
Mar 14, 2023
@Mergifyio backport 2.9.x 2.8.x 2.6.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 16, 2023
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> (cherry picked from commit 0e44353)
This was referenced Mar 16, 2023
mergify bot
pushed a commit
that referenced
this pull request
Mar 16, 2023
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> (cherry picked from commit 0e44353)
mergify bot
pushed a commit
that referenced
this pull request
Mar 16, 2023
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> (cherry picked from commit 0e44353)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WLP::add_local_reader takes the PDP mutex to protect the reader collection. WLP::remove_local_reader should take the same mutex to prevent simultaneous addition/removal from the same container.
Description
@Mergifyio backport 2.9.x 2.8.x
Fixes #3304
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist