Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17267] Added missing mutex to WLP::remove_local_reader #3311

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

jsan-rt
Copy link
Contributor

@jsan-rt jsan-rt commented Feb 20, 2023

WLP::add_local_reader takes the PDP mutex to protect the reader collection. WLP::remove_local_reader should take the same mutex to prevent simultaneous addition/removal from the same container.

Description

@Mergifyio backport 2.9.x 2.8.x

Fixes #3304

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • [NA] Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • [NA] Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • [NA] New feature has been added to the versions.md file (if applicable).
  • [NA] New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
@jsan-rt jsan-rt added this to the v2.10.0 milestone Feb 20, 2023
@jsan-rt jsan-rt marked this pull request as ready for review February 20, 2023 07:18
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Failed tests are not related with the changes

@Mario-DL Mario-DL added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Mar 14, 2023
@jsan-rt
Copy link
Contributor Author

jsan-rt commented Mar 16, 2023

@Mergifyio backport 2.9.x 2.8.x 2.6.x

@mergify
Copy link
Contributor

mergify bot commented Mar 16, 2023

backport 2.9.x 2.8.x 2.6.x

✅ Backports have been created

@MiguelCompany MiguelCompany merged commit 0e44353 into master Mar 16, 2023
@MiguelCompany MiguelCompany deleted the bugfix/missing_wlp_mutex branch March 16, 2023 09:41
mergify bot pushed a commit that referenced this pull request Mar 16, 2023
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
(cherry picked from commit 0e44353)
mergify bot pushed a commit that referenced this pull request Mar 16, 2023
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
(cherry picked from commit 0e44353)
mergify bot pushed a commit that referenced this pull request Mar 16, 2023
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
(cherry picked from commit 0e44353)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mutex lock may be missing in the WLP::remove_local_reader() method
3 participants