-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17004] Fix performance tests - Overflow in received samples #3309
[17004] Fix performance tests - Overflow in received samples #3309
Conversation
…ot from calculation Signed-off-by: Mikel Rico <mikelrico@eprosima.com>
Signed-off-by: Mikel Rico <mikelrico@eprosima.com>
Signed-off-by: Mikel Rico <mikelrico@eprosima.com>
…d of in Subscriber Signed-off-by: Mikel Rico <mikelrico@eprosima.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review pending thorough testing of the branch
Signed-off-by: Mikel Rico <mikelrico@eprosima.com>
Signed-off-by: Mikel Rico <mikelrico@eprosima.com>
Signed-off-by: Mikel Rico <mikelrico@eprosima.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@richiprosima please test this |
Signed-off-by: Mikel Rico <mikelrico@eprosima.com>
@richiprosima please test Windows and Mac again |
@richiprosima please test linux |
@richiprosima please test mac |
* Refs #17004: Fix overflow by counting received samples directly and not from calculation Signed-off-by: Mikel Rico <mikelrico@eprosima.com> * Refs #17004: Cleaning Signed-off-by: Mikel Rico <mikelrico@eprosima.com> * Refs #17004: Extend change to data_loans case Signed-off-by: Mikel Rico <mikelrico@eprosima.com> * Refs #17004: Lost samples calculation is now done in Publisher instead of in Subscriber Signed-off-by: Mikel Rico <mikelrico@eprosima.com> * Refs #17004: Fix over samples count for data_loans reception Signed-off-by: Mikel Rico <mikelrico@eprosima.com> * Refs #17004: Fix data sizes Signed-off-by: Mikel Rico <mikelrico@eprosima.com> * Refs #17004: Fix assert comparison Signed-off-by: Mikel Rico <mikelrico@eprosima.com> * Refs #17004: Erase Windows warning Signed-off-by: Mikel Rico <mikelrico@eprosima.com> --------- Signed-off-by: Mikel Rico <mikelrico@eprosima.com>
* Refs #17004: Fix overflow by counting received samples directly and not from calculation Signed-off-by: Mikel Rico <mikelrico@eprosima.com> * Refs #17004: Cleaning Signed-off-by: Mikel Rico <mikelrico@eprosima.com> * Refs #17004: Extend change to data_loans case Signed-off-by: Mikel Rico <mikelrico@eprosima.com> * Refs #17004: Lost samples calculation is now done in Publisher instead of in Subscriber Signed-off-by: Mikel Rico <mikelrico@eprosima.com> * Refs #17004: Fix over samples count for data_loans reception Signed-off-by: Mikel Rico <mikelrico@eprosima.com> * Refs #17004: Fix data sizes Signed-off-by: Mikel Rico <mikelrico@eprosima.com> * Refs #17004: Fix assert comparison Signed-off-by: Mikel Rico <mikelrico@eprosima.com> * Refs #17004: Erase Windows warning Signed-off-by: Mikel Rico <mikelrico@eprosima.com> --------- Signed-off-by: Mikel Rico <mikelrico@eprosima.com>
Description
Samples sent and throughput value numbers suffer overflow.
How to reproduce:
Run colcon test for any of the following tests:
For payloads;demand:
And recoveries:
Fix performed
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist