Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove odr-violation ASAN warning #3209

Merged
merged 3 commits into from
Jan 24, 2023
Merged

Remove odr-violation ASAN warning #3209

merged 3 commits into from
Jan 24, 2023

Conversation

rsanchez15
Copy link
Contributor

@rsanchez15 rsanchez15 commented Jan 13, 2023 •
edited by MiguelCompany
Loading

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

rsanchez15 and others added 3 commits January 13, 2023 12:52
@rsanchez15
Remove odr-violation ASAN warning
6bc34d0 
Signed-off-by: RaulSanchez <raul@eprosima.com>
Export server_ostream_separators static members to avoid windows warn…
e39207d 
…ings

Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
@rsanchez15
Replace SystemInfo get_env() function by std::getenv()
1d47b5b 
Signed-off-by: RaulSanchez <raul@eprosima.com>
MiguelCompany
MiguelCompany approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, but since the PR is exporting new symbols, it should wait for the start of the 2.10.x cycle next week

@MiguelCompany MiguelCompany added this to the v2.10.0 milestone Jan 16, 2023
@MiguelCompany MiguelCompany added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Jan 16, 2023
@rsanchez15 rsanchez15 mentioned this pull request Jan 16, 2023
Merged
5 tasks
@MiguelCompany MiguelCompany merged commit 71e278c into master Jan 24, 2023
@MiguelCompany MiguelCompany deleted the hotfix/asan-odr-violation branch January 24, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v2.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rsanchez15 @MiguelCompany