Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compilation error due to test [16371] #3196

Merged
merged 1 commit into from
Feb 24, 2023
Merged

Compilation error due to test [16371] #3196

merged 1 commit into from
Feb 24, 2023

Conversation

jparisu
Copy link
Contributor

@jparisu jparisu commented Jan 9, 2023 •
edited by JLBuenoLopez
Loading

DDSSQLFilterValueTests.test_filtered_value does not exist unless GTEST_INDIVIDUAL CMake option is used

Signed-off-by: jparisu javierparis@eprosima.com

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • [NA] Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • [NA] Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • New feature has been added to the versions.md file (if applicable).
  • [NA] New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Refs #16371: DDSSQLFilterValueTests.test_filtered_value does not exis…
6b22eee 
…t unless GTEST_INDIVIDUAL CMake option is used

Signed-off-by: jparisu <javierparis@eprosima.com>
@jsan-rt jsan-rt mentioned this pull request Feb 24, 2023
Closed
1 task
@JLBuenoLopez JLBuenoLopez added this to the v2.10.0 milestone Feb 24, 2023
JLBuenoLopez
JLBuenoLopez suggested changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, order also the required backports. I am not completely sure when this test was included but I think it is already included in 2.6.x. If so, backport to 2.6.x, 2.8.x and 2.9.x would be required.

versions.md Outdated Show resolved Hide resolved
@jparisu jparisu force-pushed the hotfix/test-compilation-individual branch from dda0e98 to 6b22eee Compare February 24, 2023 09:21
@JLBuenoLopez JLBuenoLopez added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Feb 24, 2023
@JLBuenoLopez
Copy link
Contributor

Changes do not affect CI so this PR is ready to be merged.

@MiguelCompany MiguelCompany merged commit c219131 into master Feb 24, 2023
@MiguelCompany MiguelCompany deleted the hotfix/test-compilation-individual branch February 24, 2023 09:52
@JLBuenoLopez
Copy link
Contributor

@Mergifyio backport 2.8.x 2.9.x

@mergify
Copy link
Contributor

mergify bot commented Feb 24, 2023 •
edited
Loading

backport 2.8.x 2.9.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 24, 2023
@jparisu @mergify
Fix build error when GTEST_INDIVIDUAL is OFF (#3196)
31ac748 
Signed-off-by: jparisu <javierparis@eprosima.com>
(cherry picked from commit c219131)
mergify bot pushed a commit that referenced this pull request Feb 24, 2023
@jparisu @mergify
Fix build error when GTEST_INDIVIDUAL is OFF (#3196)
92ece49 
Signed-off-by: jparisu <javierparis@eprosima.com>
(cherry picked from commit c219131)
This was referenced Feb 24, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JLBuenoLopez JLBuenoLopez JLBuenoLopez requested changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v2.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jparisu @JLBuenoLopez @MiguelCompany