Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Request-Reply example [16607] #3173

Merged
merged 6 commits into from
Feb 1, 2023
Merged

Conversation

richiware
Copy link
Member

@richiware richiware commented Dec 22, 2022

Description

This PR adds a new example to illustrate request-reply mechanism. Also it removes an obsolete client-server example.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Fast DDS test suite has been run locally.
  • N/A Changes are ABI compatible.
  • N/A Changes are API compatible.
  • N/A Documentation builds and tests pass locally.
  • N/A New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.

Related documentation PR: eProsima/Fast-DDS-docs#436

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware richiware changed the title New Request-Reply example New Request-Reply example [16607] Dec 22, 2022
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, review also the PR checklist and mark those that apply and mark as N/A those that does not. The policy is to not merge any PR which has pending tasks. Thanks in advance! 😉

examples/cpp/dds/RequestReplyExample/README.md Outdated Show resolved Hide resolved
examples/cpp/dds/RequestReplyExample/README.md Outdated Show resolved Hide resolved
examples/cpp/dds/RequestReplyExample/CMakeLists.txt Outdated Show resolved Hide resolved
examples/cpp/dds/RequestReplyExample/CalculatorServer.cpp Outdated Show resolved Hide resolved
examples/cpp/dds/RequestReplyExample/CalculatorServer.cpp Outdated Show resolved Hide resolved
examples/cpp/dds/RequestReplyExample/CalculatorServer.cpp Outdated Show resolved Hide resolved
richiware and others added 2 commits January 31, 2023 12:01
Co-authored-by: José Luis Bueno López <69244257+JLBuenoLopez-eProsima@users.noreply.github.com>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@JLBuenoLopez JLBuenoLopez added the no-test Skip CI tests if PR marked with this label label Jan 31, 2023
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JLBuenoLopez JLBuenoLopez added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Jan 31, 2023
@EduPonz EduPonz merged commit 97ca43c into master Feb 1, 2023
@EduPonz EduPonz deleted the feature/request-reply-example branch February 1, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-test Skip CI tests if PR marked with this label ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants