Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ASAN CI tests for fastdds and Discovery Server [16116] #3084

Merged
merged 5 commits into from
Nov 15, 2022
Merged

Conversation

jparisu
Copy link
Contributor

@jparisu jparisu commented Nov 11, 2022

Signed-off-by: jparisu javierparis@eprosima.com

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu jparisu changed the title Add ASAN CI tests for fastdds and Discovery Server Add ASAN CI tests for fastdds and Discovery Server [16116] Nov 11, 2022
jparisu added 4 commits November 11, 2022 12:48
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Copy link
Contributor

@rsanchez15 rsanchez15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

However, I'd upload also de .snapshot~ files from build/Discovery-Server/test/ so we can check why the tests are failing. This can be done in another PR so we can merge this one right now.

@EduPonz EduPonz added the skip-ci Automatically pass CI label Nov 15, 2022
@EduPonz EduPonz merged commit f0888e2 into master Nov 15, 2022
@EduPonz EduPonz deleted the ci/asan branch November 15, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-ci Automatically pass CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants