Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16133] Fix corner cases on external locators selection #3079

Merged
merged 8 commits into from
Nov 11, 2022
Merged

[16133] Fix corner cases on external locators selection #3079

merged 8 commits into from
Nov 11, 2022

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Nov 8, 2022 •
edited by EduPonz
Loading

Description

This PR fixes some corner cases for the communication between containers on different hosts when discovered using the external locators feature.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A Documentation builds and tests pass locally.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL Mario-DL mentioned this pull request Nov 8, 2022
Merged
@MiguelCompany MiguelCompany changed the title Avoid dropping of UDP locators on certain corner cases [16133] Avoid dropping of UDP locators on certain corner cases Nov 8, 2022
@EduPonz EduPonz added this to the v2.8.1 milestone Nov 10, 2022
@MiguelCompany MiguelCompany force-pushed the bugfix/16104 branch 2 times, most recently from 7e1a4f7 to 20b2fa5 Compare November 10, 2022 15:58
@MiguelCompany MiguelCompany marked this pull request as ready for review November 10, 2022 15:58
@MiguelCompany
Copy link
Member Author

@richiprosima Please test this

@MiguelCompany MiguelCompany changed the title [16133] Avoid dropping of UDP locators on certain corner cases [16133] Fix corner cases on external locators selection Nov 10, 2022
@MiguelCompany
Copy link
Member Author

@richiprosima Please test this

EduPonz
EduPonz suggested changes Nov 10, 2022
View reviewed changes
src/cpp/utils/Host.hpp Show resolved Hide resolved
src/cpp/rtps/RTPSDomain.cpp Show resolved Hide resolved
src/cpp/rtps/network/ExternalLocatorsProcessor.cpp Show resolved Hide resolved
@MiguelCompany
Refs #16104. Added regression test.
fde4e12 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #16104. Do not drop UDP locators when compatible SHM locators ar…
29de239 
…e received.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #16104. Static method Host::compute_id.
eb1a689 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #16104. Using metatraffic_external_unicast_locators for host id …
1442c94 
…calculation.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #16104. Automagically match localhost locators.
d466bb0
@MiguelCompany
Refs #16104. Linters.
e88bda5 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #16133. Add comment on host id hashing.
4f1b440 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
EduPonz
EduPonz previously approved these changes Nov 11, 2022
View reviewed changes
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany
Refs #16133. Remove unused variables.
88b9472 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Copy link
Member Author

@richiprosima Please test this

@EduPonz EduPonz merged commit cbe3abb into master Nov 11, 2022
@EduPonz EduPonz deleted the bugfix/16104 branch November 11, 2022 11:52
This was referenced Jul 5, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.8.1
Development

Successfully merging this pull request may close these issues.
2 participants
@MiguelCompany @EduPonz