Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fixes to tests for ASAN #3052

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Add fixes to tests for ASAN #3052

merged 1 commit into from
Oct 31, 2022

Conversation

jparisu
Copy link
Contributor

@jparisu jparisu commented Oct 28, 2022 •
edited by rsanchez15
Loading

Signed-off-by: jparisu javierparis@eprosima.com

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Add fixes to tests for ASAN
6c26729 
Signed-off-by: jparisu <javierparis@eprosima.com>
rsanchez15
rsanchez15 approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@rsanchez15 rsanchez15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EduPonz EduPonz merged commit 2f2cc52 into master Oct 31, 2022
@EduPonz EduPonz deleted the fix/StatisticsDomainParticipantMockTests branch October 31, 2022 14:35
@jparisu jparisu mentioned this pull request Nov 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsanchez15 rsanchez15 rsanchez15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jparisu @rsanchez15 @EduPonz