Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove getGuid implementation in StatefulReader mock #3050

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Remove getGuid implementation in StatefulReader mock #3050

merged 1 commit into from
Nov 3, 2022

Conversation

rsanchez15
Copy link
Contributor

@rsanchez15 rsanchez15 commented Oct 28, 2022 •
edited by juanlofer-eprosima
Loading

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@rsanchez15
Remove getGuid implementation in StatefulReader mock
af3ac83 
Signed-off-by: RaulSanchez <raul@eprosima.com>
@rsanchez15 rsanchez15 mentioned this pull request Oct 28, 2022
Closed
@rsanchez15
Copy link
Contributor Author

@richiprosima Please test this

juanlofer-eprosima
juanlofer-eprosima approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, failing tests seem unrelated (merger please verify)

@EduPonz
Copy link

EduPonz commented Oct 31, 2022

@richiprosima please test mac

@EduPonz
Copy link

EduPonz commented Oct 31, 2022

@richiprosima please test discovery-server

@JLBuenoLopez
Copy link
Contributor

@richiprosima Please test mac again

@JLBuenoLopez
Copy link
Contributor

@richiprosima please test mac one more time

JLBuenoLopez
JLBuenoLopez approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

CI failures are unrelated

@MiguelCompany MiguelCompany merged commit b043c99 into master Nov 3, 2022
@MiguelCompany MiguelCompany deleted the hotfix/asan-security branch November 3, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JLBuenoLopez JLBuenoLopez JLBuenoLopez approved these changes

@juanlofer-eprosima juanlofer-eprosima juanlofer-eprosima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rsanchez15 @EduPonz @JLBuenoLopez @juanlofer-eprosima @MiguelCompany