Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ASAN errors in API tests [15965] #3019

Merged
merged 8 commits into from
Nov 7, 2022
Merged

Fix ASAN errors in API tests [15965] #3019

merged 8 commits into from
Nov 7, 2022

Conversation

jparisu
Copy link
Contributor

@jparisu jparisu commented Oct 18, 2022 •
edited
Loading

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@jparisu jparisu marked this pull request as ready for review October 24, 2022 07:25
@jsan-rt
Copy link
Contributor

jsan-rt commented Oct 24, 2022

@richiprosima please test this

@jparisu jparisu mentioned this pull request Oct 27, 2022
Closed
@rsanchez15
Copy link
Contributor

@richiprosima Please test this

@rsanchez15
Copy link
Contributor

@richiprosima Please test this

1 similar comment
@rsanchez15
Copy link
Contributor

@richiprosima Please test this

@jparisu
Copy link
Contributor Author

jparisu commented Nov 3, 2022

@richiprosima Please test this

@jparisu
Copy link
Contributor Author

jparisu commented Nov 3, 2022

@richiprosima Please test this

@jparisu
Copy link
Contributor Author

jparisu commented Nov 3, 2022

@richiprosima Please test this

@jparisu
Copy link
Contributor Author

jparisu commented Nov 4, 2022

@richiprosima Please test this

jparisu added 6 commits November 4, 2022 09:50
Refs #15965: Avoid calling StopAll in RTPSDomain before DomainPartici…
410b866 
…pantFactory

Signed-off-by: jparisu <javierparis@eprosima.com>
Refs #15965: Fix race condition in ParticipantProxyPhysicalData
9bab8b5 
Signed-off-by: jparisu <javierparis@eprosima.com>
Refs #15965: Modify ChainingTransport to hold uniqueptrs
de85a5f 
Signed-off-by: jparisu <javierparis@eprosima.com>
Refs #15965: Remove SystemInfo from sources which creates twice same …
43276f5 
…variable

Signed-off-by: jparisu <javierparis@eprosima.com>
Refs #15965: apply suggestionsg
791928a 
Signed-off-by: jparisu <javierparis@eprosima.com>
Refs #15965: add small fixes
27a1fc3 
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu
Copy link
Contributor Author

jparisu commented Nov 4, 2022

@richiprosima Please test this

Refs #15965: uncrustify
84548f0 
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu
Copy link
Contributor Author

jparisu commented Nov 4, 2022

@richiprosima Please test this

Refs #15965: fix typo
c33bfda 
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu
Copy link
Contributor Author

jparisu commented Nov 4, 2022

@richiprosima Please test this

@jparisu
Copy link
Contributor Author

jparisu commented Nov 4, 2022

ATTENTION: uncrustify failure must not be taken into account, as the proposed fix is a gramatical error.

@JLBuenoLopez
Copy link
Contributor

@richiprosima please test this again

JLBuenoLopez
JLBuenoLopez approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failures are unrelated. Thanks @jparisu!

@MiguelCompany MiguelCompany merged commit 9851cda into master Nov 7, 2022
@MiguelCompany MiguelCompany deleted the fix/asan-API branch November 7, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsanchez15 rsanchez15 rsanchez15 approved these changes

@JLBuenoLopez JLBuenoLopez JLBuenoLopez approved these changes

@MiguelCompany MiguelCompany Awaiting requested review from MiguelCompany

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jparisu @jsan-rt @rsanchez15 @JLBuenoLopez @MiguelCompany