Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak in tests [15996] #3017

Merged
merged 2 commits into from
Nov 3, 2022
Merged

Fix memory leak in tests [15996] #3017

merged 2 commits into from
Nov 3, 2022

Conversation

jparisu
Copy link
Contributor

@jparisu jparisu commented Oct 17, 2022 •
edited
Loading

Signed-off-by: jparisu javierparis@eprosima.com

Description

Small PR that fixes a memory leak of an object created in test and never destroyed.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

jparisu added 2 commits October 17, 2022 10:21
Fix memory leak in test
9d8afcf 
Signed-off-by: jparisu <javierparis@eprosima.com>
Fix error in BlackboxTests_RTPS
d37525f 
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu jparisu changed the title Fix memory leak in test Fix memory leak in tests Oct 17, 2022
@jparisu jparisu changed the title Fix memory leak in tests Fix memory leak in tests [15996] Oct 24, 2022
@jparisu jparisu mentioned this pull request Oct 27, 2022
Closed
@rsanchez15
Copy link
Contributor

@richiprosima please test this

JLBuenoLopez
JLBuenoLopez approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failures seem unrelated

@MiguelCompany MiguelCompany merged commit 7652f50 into master Nov 3, 2022
@MiguelCompany MiguelCompany deleted the fix/communication-test-leak branch November 3, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JLBuenoLopez JLBuenoLopez JLBuenoLopez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jparisu @rsanchez15 @JLBuenoLopez @MiguelCompany