Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include the right header when building for iOS #3002

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Include the right header when building for iOS #3002

merged 1 commit into from
Mar 27, 2023

Conversation

light-tech
Copy link
Contributor

Signed-off-by: Lightech lightech@outlook.com

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@light-tech
Include the right header when building for iOS
448a18f 
Signed-off-by: Lightech <lightech@outlook.com>
MiguelBarro
MiguelBarro previously approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@MiguelBarro MiguelBarro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelBarro MiguelBarro dismissed their stale review October 6, 2022 13:26

Needs further analysis

@light-tech
Copy link
Contributor Author

Please refer to https://github.com/light-tech/ROS2-On-iOS for ROS2 building scripts for the iOS platform.

@MiguelCompany
Copy link
Member

@richiprosima Please test this

@MiguelCompany MiguelCompany added this to the v2.10.0 milestone Feb 10, 2023
@MiguelCompany MiguelCompany added the ci-pending PR which CI is running label Feb 10, 2023
@EduPonz EduPonz requested a review from jsan-rt March 17, 2023 06:55
@jsan-rt
Copy link
Contributor

jsan-rt commented Mar 17, 2023

@richiprosima please test this

jsan-rt
jsan-rt approved these changes Mar 26, 2023
View reviewed changes
Copy link
Contributor

@jsan-rt jsan-rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution,

Mac CI (and all the other platforms' for that matter) seems unaffected by the changes, so I'll go ahead and approve this.

@MiguelCompany MiguelCompany merged commit c24bef2 into eProsima:master Mar 27, 2023
@MiguelCompany
Copy link
Member

@Mergifyio backport 2.9.x 2.8.x 2.6.x 2.1.x

@mergify
Copy link
Contributor

mergify bot commented Mar 27, 2023 •
edited
Loading

backport 2.9.x 2.8.x 2.6.x 2.1.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 27, 2023
@light-tech @mergify
Include the right header when building for iOS (#3002)
aeacc65 
Signed-off-by: Lightech <lightech@outlook.com>
(cherry picked from commit c24bef2)
mergify bot pushed a commit that referenced this pull request Mar 27, 2023
@light-tech @mergify
Include the right header when building for iOS (#3002)
e8bcb4b 
Signed-off-by: Lightech <lightech@outlook.com>
(cherry picked from commit c24bef2)
@mergify mergify bot mentioned this pull request Mar 27, 2023
Merged
mergify bot pushed a commit that referenced this pull request Mar 27, 2023
@light-tech @mergify
Include the right header when building for iOS (#3002)
a8b0917 
Signed-off-by: Lightech <lightech@outlook.com>
(cherry picked from commit c24bef2)
This was referenced Mar 27, 2023
Merged
Merged
mergify bot pushed a commit that referenced this pull request Mar 27, 2023
@light-tech @mergify
Include the right header when building for iOS (#3002)
ac0e051 
Signed-off-by: Lightech <lightech@outlook.com>
(cherry picked from commit c24bef2)

# Conflicts:
#	src/cpp/utils/IPFinder.cpp
@mergify mergify bot mentioned this pull request Mar 27, 2023
Closed
JLBuenoLopez pushed a commit that referenced this pull request Apr 13, 2023
@mergify @light-tech
Include the right header when building for iOS (#3002) (#3402)
d3fcd58 
Signed-off-by: Lightech <lightech@outlook.com>
(cherry picked from commit c24bef2)

Co-authored-by: light-tech <lightech@outlook.com>
@JLBuenoLopez JLBuenoLopez mentioned this pull request Jun 12, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsan-rt jsan-rt jsan-rt approved these changes

@MiguelBarro MiguelBarro MiguelBarro left review comments

Assignees
No one assigned
Labels
ci-pending PR which CI is running
Projects
None yet
Milestone
v2.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@light-tech @MiguelCompany @jsan-rt @MiguelBarro