Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs 15852: Fixing ReadConditions missing header on DataReader header #3001

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

MiguelBarro
Copy link
Contributor

Description

The DataReader header only includes a forward declaration of ReadCondition.
The following code:

        // create condition
        auto cond = reader->create_readcondition(ANY_SAMPLE_STATE, ANY_VIEW_STATE, ALIVE_INSTANCE_STATE);

        // attach to the corresponding wait set
        wait_set.attach_condition(*cond);

will fail with the message:

  • GCC error: cannot convert 'ReadCondition*' to 'Condition*' in initialization
  • MSVC error C2440: 'initializing': cannot convert from 'ReadCondition *' to 'Condition *
    The DataReader header must include the definition of ReadCondition.

The ReadCondition blackbox testing works now without including the ReadCondition header.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
@MiguelBarro MiguelBarro added the no-test Skip CI tests if PR marked with this label label Oct 6, 2022
@MiguelBarro MiguelBarro self-assigned this Oct 6, 2022
@MiguelCompany
Copy link
Member

@richiprosima Please test mac

Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany MiguelCompany merged commit 1578b72 into master Oct 7, 2022
@MiguelCompany MiguelCompany deleted the bugfix/DataReader_header branch October 7, 2022 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-test Skip CI tests if PR marked with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants