Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cmake_minimum_required due to target_link_options [15378] #2907

Merged
merged 1 commit into from
Aug 11, 2022
Merged

Fix cmake_minimum_required due to target_link_options [15378] #2907

merged 1 commit into from
Aug 11, 2022

Conversation

richiware
Copy link
Member

@richiware richiware commented Aug 5, 2022 •
edited
Loading

Description

There is being used target_link_options in our CMakeLists.txt files which was incorporated in CMake 3.13. This PR
fixes the cmake_minimum_required.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@richiware
Fix cmake_minimum_required due to target_link_options
302c04e 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware richiware added the no-test Skip CI tests if PR marked with this label label Aug 5, 2022
@richiware
Copy link
Member Author

@Mergifyio backport 2.3.x

@mergify
Copy link
Contributor

mergify bot commented Aug 5, 2022 •
edited
Loading

backport 2.3.x

✅ Backports have been created

@richiware richiware changed the title Fix cmake_minimum_required due to target_link_options Fix cmake_minimum_required due to target_link_options [15378] Aug 5, 2022
jsan-rt
jsan-rt approved these changes Aug 7, 2022
View reviewed changes
Copy link
Contributor

@jsan-rt jsan-rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richiware
Copy link
Member Author

@richiprosima Please test mac

@richiware
Copy link
Member Author

@richiprosima Please test mac

@richiware
Copy link
Member Author

@richiprosima Please test mac

@richiware richiware merged commit bf8f366 into 2.6.x Aug 11, 2022
@richiware richiware deleted the bugfix/cmake-3.5 branch August 11, 2022 09:41
@mergify mergify bot mentioned this pull request Aug 11, 2022
Merged
richiware added a commit that referenced this pull request Aug 11, 2022
@richiware
Fix cmake_minimum_required due to target_link_options (#2907)
b3ffc9e 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
(cherry picked from commit bf8f366)
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
richiware added a commit that referenced this pull request Aug 12, 2022
@mergify @richiware
Fix cmake_minimum_required due to target_link_options (#2907) (#2916)
0357fa9 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
(cherry picked from commit bf8f366)
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Co-authored-by: Ricardo González <ricardo@richiware.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsan-rt jsan-rt jsan-rt approved these changes

Assignees
No one assigned
Labels
no-test Skip CI tests if PR marked with this label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richiware @jsan-rt