Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lock guard at changing SHM port listener status members [15261] #2883

Merged
merged 1 commit into from
Jul 28, 2022
Merged

Add lock guard at changing SHM port listener status members [15261] #2883

merged 1 commit into from
Jul 28, 2022

Conversation

rsanchez15
Copy link
Contributor

@rsanchez15 rsanchez15 commented Jul 27, 2022 •
edited
Loading

This fix solves multiple dataraces in SharedMemGlobal.

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany
Copy link
Member

@richiprosima Please test Windows

@rsanchez15
Copy link
Contributor Author

@richiprosima Please test this

@rsanchez15 rsanchez15 changed the title [15261] Add lock guard at changing SHM port listener status members Add lock guard at changing SHM port listener status members [15261] Jul 27, 2022
jparisu
jparisu approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@jparisu jparisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany MiguelCompany merged commit dbb882d into master Jul 28, 2022
@MiguelCompany MiguelCompany deleted the tsan/shm-global branch July 28, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jparisu jparisu jparisu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rsanchez15 @MiguelCompany @jparisu