Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store EDP listener pointers before being used [15216] #2857

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Store EDP listener pointers before being used [15216] #2857

merged 1 commit into from
Jul 21, 2022

Conversation

richiware
Copy link
Member

@richiware richiware commented Jul 20, 2022 •
edited
Loading

Signed-off-by: Ricardo González Moreno ricardo@richiware.dev

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@richiware
Refs #15215. Fix bug using nullptr listener
bffae62 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware richiware changed the title Store EDP listener pointers before being used Store EDP listener pointers before being used [15216] Jul 20, 2022
MiguelCompany
MiguelCompany approved these changes Jul 20, 2022
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany MiguelCompany merged commit 0014b01 into master Jul 21, 2022
@MiguelCompany MiguelCompany deleted the bugfix/fix-listener-null branch July 21, 2022 05:21
Blast545 added a commit to Blast545/Fast-DDS that referenced this pull request Jul 21, 2022
@Blast545
Revert "Store EDP listener pointers before being used (eProsima#2857)"
0060fdd 
This reverts commit 0014b01.

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richiware @MiguelCompany