[15174] Add new CMake option to allow users to enforce use of our third party shared_mutex #2846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 15, 2022 10:21
…ies component. This pull request mandatory piggyback. Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
…mutex use Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
jsan-rt
suggested changes
Jul 15, 2022
Co-authored-by: jsantiago-eProsima <90755661+jsantiago-eProsima@users.noreply.github.com>
… config.h inclusion. Make sure all compilation units in the library use the same shared_mutex implementation. Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
|
@richiprosima please test this |
…he config.h is not included. Prevents future issues including shared_mutex.hpp Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
MiguelBarro
force-pushed
the
feature/force_thirdparty_shared_mutex
branch
2 times, most recently
from
2315cab
to
666f528
Compare
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
MiguelBarro
changed the title
|
@richiprosima Please test this |
jsan-rt
approved these changes
Jul 21, 2022
|
LGTM |
Blast545
added a commit
to Blast545/Fast-DDS
that referenced
this pull request
Jul 21, 2022
…rd party shared_mutex (eProsima#2846)" This reverts commit dee1d4b. Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The CMake option USE_THIRDPARTY_SHARED_MUTEX is added as OFF by default.
By turning it on users can enforce the use of our boost-like implementation of shared_mutex.
Otherwise, the third-party implementation will be used only if the build framework lacks a shared_mutex.
Contributor Checklist
versions.mdfile (if applicable).eProsima/Fast-DDS-docs#384
Reviewer Checklist