Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: liveliness core dump caused by omit mutex lock #2828

Merged
merged 3 commits into from
Jul 14, 2022
Merged

fix: liveliness core dump caused by omit mutex lock #2828

merged 3 commits into from
Jul 14, 2022

Conversation

dameidu
Copy link
Contributor

@dameidu dameidu commented Jul 10, 2022 •
edited
Loading

fix: liveliness core dump caused by omit mutex lock

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@gavanderhoorn gavanderhoorn mentioned this pull request Jul 11, 2022
Closed
Refactor that includes the fix and speeds things up
4724a2f 
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
@MiguelBarro
Copy link
Contributor

Your correction has encouraged us to refactor a little the LivelinessManager 😂

@MiguelBarro
Copy link
Contributor

@richiprosima Please test this

Fixing Clang warnings
6aa041e 
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
@MiguelBarro
Copy link
Contributor

@richiprosima Please test this

jsan-rt
jsan-rt approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@jsan-rt jsan-rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany MiguelCompany merged commit 796176a into eProsima:master Jul 14, 2022
@MiguelCompany
Copy link
Member

@Mergifyio backport 2.6.x

mergify bot pushed a commit that referenced this pull request Jul 14, 2022
@dameidu @mergify
Fix liveliness core dump caused by unprotected code (#2828)
af258f0 
* fix:  liveliness core dump caused by omit mutex lock

* Refactor that includes the fix and speeds things up

Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>

* Fixing Clang warnings

Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>

Co-authored-by: jim <jim@jim-ubuntu>
Co-authored-by: Miguel Barro <miguelbarro@eprosima.com>
(cherry picked from commit 796176a)
@mergify mergify bot mentioned this pull request Jul 14, 2022
Merged
@mergify
Copy link
Contributor

mergify bot commented Jul 14, 2022

backport 2.6.x

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsan-rt jsan-rt jsan-rt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dameidu @MiguelBarro @MiguelCompany @jsan-rt