Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15007] Add dll support to Dynamic Types API #2783

Merged
merged 3 commits into from
Jun 29, 2022
Merged

[15007] Add dll support to Dynamic Types API #2783

merged 3 commits into from
Jun 29, 2022

Conversation

jparisu
Copy link
Contributor

@jparisu jparisu commented Jun 28, 2022 •
edited by MiguelCompany
Loading

Signed-off-by: jparisu javierparis@eprosima.com

Description

When used in plotjuggler fastdds plugin : https://github.com/eProsima/plotjuggler-fastdds-plugins
there has been a problem while using the Dynamic Types API in Windows because some methods does not have the dll support.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Refs #15007: Add dll support to Dynamic Types API
1c1b30b 
Signed-off-by: jparisu <javierparis@eprosima.com>
@JLBuenoLopez JLBuenoLopez added this to the v2.7.0 milestone Jun 28, 2022
MiguelCompany
MiguelCompany previously approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please fix uncrustify

Refs #15007: uncrustify
3bdd14d 
Signed-off-by: jparisu <javierparis@eprosima.com>
jsan-rt
jsan-rt suggested changes Jun 28, 2022
View reviewed changes
include/fastrtps/types/TypeDescriptor.h Outdated Show resolved Hide resolved
include/fastrtps/types/TypeDescriptor.h Outdated Show resolved Hide resolved
include/fastrtps/types/TypeDescriptor.h Outdated Show resolved Hide resolved
Refs #15007: apply suggestions
ac94ff9 
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu jparisu marked this pull request as draft June 28, 2022 08:44
@jparisu
Copy link
Contributor Author

jparisu commented Jun 28, 2022

Waiting for PR eProsima/fastdds-visualizer-plugin#10 to check this branch fixes the problem

@jparisu jparisu marked this pull request as ready for review June 28, 2022 09:44
@jparisu
Copy link
Contributor Author

jparisu commented Jun 28, 2022 •
edited
Loading

Ready to check and merge 👍

@MiguelCompany MiguelCompany added no-test Skip CI tests if PR marked with this label no-aarch Skip build & test for aarch64 labels Jun 28, 2022
@MiguelCompany
Copy link
Member

@richiprosima Please test this

@jparisu jparisu mentioned this pull request Jun 28, 2022
Merged
@MiguelCompany MiguelCompany merged commit 47d8caf into master Jun 29, 2022
@MiguelCompany MiguelCompany deleted the feature/dynamic-types-dll branch June 29, 2022 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsan-rt jsan-rt jsan-rt approved these changes

@MiguelCompany MiguelCompany MiguelCompany left review comments

Assignees
No one assigned
Labels
no-aarch Skip build & test for aarch64 no-test Skip CI tests if PR marked with this label
Projects
None yet
Milestone
v2.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jparisu @MiguelCompany @jsan-rt @JLBuenoLopez