Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14925] Add interfaces for ReadCondition #2778

Merged
merged 6 commits into from
Jun 30, 2022

Conversation

MiguelCompany
Copy link
Member

Description

This PR adds the necessary changes to the public API in order to support ReadCondition.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible. <-- Note: we are breaking the API on unsupported methods
  • Documentation builds and tests pass locally.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany added no-test Skip CI tests if PR marked with this label no-aarch Skip build & test for aarch64 labels Jun 24, 2022
@MiguelCompany MiguelCompany added this to the v2.7.0 milestone Jun 24, 2022
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Copy link
Member Author

@richiprosima Please test this

@MiguelBarro MiguelBarro self-requested a review June 29, 2022 12:05
Copy link
Contributor

@MiguelBarro MiguelBarro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According with DDS 1.4 2.2.2.5.3.10 the following DataReader methods should fail if the given condition is not attach to the reader. Thus, they cannot neither default nor accept a nullptr:

  • read_w_condition()
  • take_w_condition()
  • read_next_instance_w_condition()
  • take_next_instance_w_condition()

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Copy link
Member Author

@richiprosima Please test this

Copy link
Contributor

@MiguelBarro MiguelBarro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the reasonable defaults

@MiguelCompany MiguelCompany changed the title Add interfaces for ReadCondition [14925] Add interfaces for ReadCondition Jun 30, 2022
Copy link
Contributor

@MiguelBarro MiguelBarro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
It's a pity to be forced to remove all default argument values to keep the standard parameter order 🙄

@MiguelCompany
Copy link
Member Author

@richiprosima Please test mac

@MiguelCompany MiguelCompany merged commit 3e6ba6f into master Jun 30, 2022
@MiguelCompany MiguelCompany deleted the feature/readcondition/interfaces branch June 30, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-aarch Skip build & test for aarch64 no-test Skip CI tests if PR marked with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants