Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add implementation of DomainParticipant::find_topic #2769

Merged
merged 2 commits into from
Jun 22, 2022
Merged

Add implementation of DomainParticipant::find_topic #2769

merged 2 commits into from
Jun 22, 2022

Conversation

MiguelCompany
Copy link
Member

Description

This PR adds tests and implementation for DomainParticipant::find_topic.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany
Add tests for DomainParticipant::find_topic (#2698)
8ba2e66 
* Refs #14615. Basic test infrastructure.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Add test DDS-DP-FT-01.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Mock type support..

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Add test DDS-DP-FT-02.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Utility method to compare two topics.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Add test DDS-DP-FT-03.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Utility method to create test topic.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Add test DDS-DP-FT-04.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Add test DDS-DP-FT-05.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Remove from ParticipantTests.UnsupportedMethods.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Suggestions.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Add implementation of DomainParticipant::find_topic (#2716)
4e44ea9 
* Refs #14615. Added basic TopicProxy class.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Topic holds TopicProxy, which is created by DomainParticipantImpl.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. TopicProxy constructs and owns Topic.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. TopicImpl is not TopicDescriptionImpl and does not hold user topic pointer.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. TopicImpl constructor is public.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. TopicImpl header cleanup.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Added TopicProxyFactory class with basic interface.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. TopicProxyFactory empty implementation.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. TopicProxyFactory holds TopicImpl by composition.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. TopicProxyFactory holds list of created proxy objects.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Implementation of TopicProxyFactory::can_be_deleted.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Implementation of TopicProxyFactory::delete_topic.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Implementation of TopicProxyFactory::create_topic.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Adding enable_topic and get_topic to TopicProxyFactory.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. DomainParticipantImpl uses TopicProxyFactory.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Move find_topic to DomainParticipantImpl.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Notify a condition when a topic is created.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Implementation of DomainParticipantImpl::find_topic.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Fixed segfault on test.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Fixed return value on delete_topic.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Avoid using input topic on delete_topic.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Always use input listener.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Internal set_listener methods return void.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. TopicProxyFactory::for_each.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. TopicImpl holds pointer to TopicProxyFactory.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. DomainParticipantImpl::set_topic_listener.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. TopicImpl::set_listener with mask.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Topic::set_listener propagates mask.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Correctly handling infinite timeout.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Uncrustify.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Fixed non-c++11 code.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Improve doxydoc.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #14615. Assertion on dynamic_cast result.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany added this to the v2.7.0 milestone Jun 21, 2022
@MiguelCompany
Copy link
Member Author

@richiprosima Please test mac

@MiguelCompany MiguelCompany merged commit 39b5148 into master Jun 22, 2022
@MiguelCompany MiguelCompany deleted the feature/find_topic/main branch June 22, 2022 07:58
sky-fire pushed a commit to sky-fire/Fast-DDS that referenced this pull request Sep 1, 2022
@richiware @MiguelCompany @JLBuenoLopez
Add transport interface to concatenate transports (eProsima#2103)
7b97f19 
* Squash of low-bandwidth-plugins development:

Refs eProsima#2731. Initial version of DataTransformTransport

Refs eProsima#2731. DataTransformTransport implementation complete + unit test

Refs eProsima#2731. Refactor of DataTransformTransport with middle class ChainingTransport

Refs eProsima#2752. Refactor to pass participant properties on transport creation

Refs eProsima#2691. Added some utils to StringMatching class

Refs eProsima#2693. Headers reduction transport implementation

Refs eProsima#2759. Blackbox test and bug fixing

Refs eProsima#2759. Fixing compiler warnings

Refs eProsima#2692. Added Payload Compression Transport (ZLIB only)

Refs eProsima#2692. Added BlackBox test for ZLib transport

Refs eProsima#2692. Added BZIP2 compression

Refs eProsima#2692. Added BlackBox test for BZip2 transport

Refs eProsima#2692. Fixing compiler warnings

Refs eProsima#2692. Added automatic compression implementation

Refs eProsima#2692. Added blackbox test for automatic compression

Refs eProsima#2692. Only compiling compression transport when compression libraries are found

Refs eProsima#2727. Added source timestamp transport

Refs eProsima#2727. Added blackbox test for source timestamp transport

Refs eProsima#2693. Removing unsupported entity ids

Refs eProsima#2693. Fix of bug in HeaderReduction_Recover

Refs eProsima#2769. Documenting interfaces and some optimizations

Refs eProsima#2691. Added blackbox test chaining several transports

Better doc on some transports

Refs eProsima#2787. Fixed bug in SourceTimestamp transport

Refs eProsima#2787. Added examples to test interoperability

Refs eProsima#2787. Interop example improved

Refs eProsima#2787. Added dump capabiliy to HeaderReductionTransport

Refs eProsima#2787. Added dump to test participants

Refs eProsima#2787. Fixed bug in SourceTimestampTransport

Refs eProsima#2787. Improving tests and dump

Refs eProsima#2787. Improving example

Refs eProsima#2787. Fixing entiy id packing

Refs eProsima#2787. Message sent improved

Refs eProsima#2787. Added dump of low level data

Refs eProsima#2787. Testing improvements

Refs eProsima#2787. Changing data type

Refs eProsima#2787. Test data

Refs eProsima#2787. Adding parameters to endpoints

Refs eProsima#2787. Conditional compilation of debug dump

Refs eProsima#2691. Changing example name

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Fixing compilation errors after rebase.

Signed-off-by: Ricardo González Moreno <correoricky@gmail.com>

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* New features

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #10121. Fix error creating output channel.

Signed-off-by: Ricardo González Moreno <correoricky@gmail.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #12290. Uncrustify

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Moved example to other repo

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #12290. Fix warning on windows

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #12290. Fix warning on windows

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #12290. Fix warnings on Mac

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs 12290. Fix old uncrustify

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Apply suggestions from code review

Co-authored-by: José Luis Bueno López <69244257+JLBuenoLopez-eProsima@users.noreply.github.com>

* Refs #12290. Apply suggestions.

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #12290. Apply suggestions

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #12290. Add blackbox test.

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #12290. Fix license

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #12290. Fix warning on mac

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Co-authored-by: Miguel Company <MiguelCompany@eprosima.com>
Co-authored-by: Luis LG. Gasco <luisgasco@eprosima.com>
Co-authored-by: José Luis Bueno López <69244257+JLBuenoLopez-eProsima@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.7.0
Development

Successfully merging this pull request may close these issues.
1 participant
@MiguelCompany