Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14615] Add implementation of DomainParticipant::find_topic #2716

Merged
merged 33 commits into from
Jun 21, 2022
Merged

[14615] Add implementation of DomainParticipant::find_topic #2716

merged 33 commits into from
Jun 21, 2022

Commits on May 27, 2022

  1. Refs #14615. Added basic TopicProxy class. 

    Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
    @MiguelCompany
    MiguelCompany committed May 27, 2022
    Configuration menu
    Copy the full SHA
    0998819 View commit details
    Browse the repository at this point in the history

  2. Refs #14615. Topic holds TopicProxy, which is created by DomainPartic… 

    …ipantImpl.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
    @MiguelCompany
    MiguelCompany committed May 27, 2022
    Configuration menu
    Copy the full SHA
    322e302 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2022

  1. Refs #14615. TopicProxy constructs and owns Topic. 

    Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
    @MiguelCompany
    MiguelCompany committed May 31, 2022
    Configuration menu
    Copy the full SHA
    c976bc0 View commit details
    Browse the repository at this point in the history

  2. Refs #14615. TopicImpl is not TopicDescriptionImpl and does not hold … 

    …user topic pointer.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
    @MiguelCompany
    MiguelCompany committed May 31, 2022
    Configuration menu
    Copy the full SHA
    637807f View commit details
    Browse the repository at this point in the history

  3. Refs #14615. TopicImpl constructor is public. 

    Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
    @MiguelCompany
    MiguelCompany committed May 31, 2022
    Configuration menu
    Copy the full SHA
    8ad653a View commit details
    Browse the repository at this point in the history

  4. Refs #14615. TopicImpl header cleanup. 

    Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
    @MiguelCompany
    MiguelCompany committed May 31, 2022
    Configuration menu
    Copy the full SHA
    9eb8c55 View commit details
    Browse the repository at this point in the history

  5. Refs #14615. Added TopicProxyFactory class with basic interface. 

    Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
    @MiguelCompany
    MiguelCompany committed May 31, 2022
    Configuration menu
    Copy the full SHA
    b0149c7 View commit details
    Browse the repository at this point in the history

  6. Refs #14615. TopicProxyFactory empty implementation. 

    Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
    @MiguelCompany
    MiguelCompany committed May 31, 2022
    Configuration menu
    Copy the full SHA
    d6dde52 View commit details
    Browse the repository at this point in the history

  7. Refs #14615. TopicProxyFactory holds TopicImpl by composition. 

    Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
    @MiguelCompany
    MiguelCompany committed May 31, 2022
    Configuration menu
    Copy the full SHA
    f264f66 View commit details
    Browse the repository at this point in the history

  8. Refs #14615. TopicProxyFactory holds list of created proxy objects. 

    Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
    @MiguelCompany
    MiguelCompany committed May 31, 2022
    Configuration menu
    Copy the full SHA
    8f4654a View commit details
    Browse the repository at this point in the history

  9. Refs #14615. Implementation of TopicProxyFactory::can_be_deleted. 

    Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
    @MiguelCompany
    MiguelCompany committed May 31, 2022
    Configuration menu
    Copy the full SHA
    520220f View commit details
    Browse the repository at this point in the history

  10. Refs #14615. Implementation of TopicProxyFactory::delete_topic. 

    Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
    @MiguelCompany
    MiguelCompany committed May 31, 2022
    Configuration menu
    Copy the full SHA
    b414a93 View commit details
    Browse the repository at this point in the history

  11. Refs #14615. Implementation of TopicProxyFactory::create_topic. 

    Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
    @MiguelCompany
    MiguelCompany committed May 31, 2022
    Configuration menu
    Copy the full SHA
    652ce67 View commit details
    Browse the repository at this point in the history

  12. Refs #14615. Adding enable_topic and get_topic to TopicProxyFactory. 

    Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
    @MiguelCompany
    MiguelCompany committed May 31, 2022
    Configuration menu
    Copy the full SHA
    3655203 View commit details
    Browse the repository at this point in the history

  13. Refs #14615. DomainParticipantImpl uses TopicProxyFactory. 

    Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
    @MiguelCompany
    MiguelCompany committed May 31, 2022
    Configuration menu
    Copy the full SHA
    dc5cb1c View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2022

  1. Refs #14615. Move find_topic to DomainParticipantImpl. 

    Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
    @MiguelCompany
    MiguelCompany committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    5381372 View commit details
    Browse the repository at this point in the history

  2. Refs #14615. Notify a condition when a topic is created. 

    Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
    @MiguelCompany
    MiguelCompany committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    49ea325 View commit details
    Browse the repository at this point in the history

  3. Refs #14615. Implementation of DomainParticipantImpl::find_topic. 

    Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
    @MiguelCompany
    MiguelCompany committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    c019872 View commit details
    Browse the repository at this point in the history

  4. Refs #14615. Fixed segfault on test. 

    Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
    @MiguelCompany
    MiguelCompany committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    3132215 View commit details
    Browse the repository at this point in the history

  5. Refs #14615. Fixed return value on delete_topic. 

    Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
    @MiguelCompany
    MiguelCompany committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    7932671 View commit details
    Browse the repository at this point in the history

  6. Refs #14615. Avoid using input topic on delete_topic. 

    Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
    @MiguelCompany
    MiguelCompany committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    41c0783 View commit details
    Browse the repository at this point in the history

  7. Refs #14615. Always use input listener. 

    Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
    @MiguelCompany
    MiguelCompany committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    47f16a1 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2022

  1. Refs #14615. Internal set_listener methods return void. 

    Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
    @MiguelCompany
    MiguelCompany committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    b72309c View commit details
    Browse the repository at this point in the history

  2. Refs #14615. TopicProxyFactory::for_each. 

    Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
    @MiguelCompany
    MiguelCompany committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    157d836 View commit details
    Browse the repository at this point in the history

  3. Refs #14615. TopicImpl holds pointer to TopicProxyFactory. 

    Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
    @MiguelCompany
    MiguelCompany committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    afc7f3c View commit details
    Browse the repository at this point in the history

  4. Refs #14615. DomainParticipantImpl::set_topic_listener. 

    Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
    @MiguelCompany
    MiguelCompany committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    44a3425 View commit details
    Browse the repository at this point in the history

  5. Refs #14615. TopicImpl::set_listener with mask. 

    Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
    @MiguelCompany
    MiguelCompany committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    5785f76 View commit details
    Browse the repository at this point in the history

  6. Refs #14615. Topic::set_listener propagates mask. 

    Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
    @MiguelCompany
    MiguelCompany committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    9262a42 View commit details
    Browse the repository at this point in the history

  7. Refs #14615. Correctly handling infinite timeout. 

    Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
    @MiguelCompany
    MiguelCompany committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    fe4dee4 View commit details
    Browse the repository at this point in the history

  8. Refs #14615. Uncrustify. 

    Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
    @MiguelCompany
    MiguelCompany committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    0e9e5c8 View commit details
    Browse the repository at this point in the history

  9. Refs #14615. Fixed non-c++11 code. 

    Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
    @MiguelCompany
    MiguelCompany committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    eadf8af View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2022

  1. Refs #14615. Improve doxydoc. 

    Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
    @MiguelCompany
    MiguelCompany committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    8af4751 View commit details
    Browse the repository at this point in the history

  2. Refs #14615. Assertion on dynamic_cast result. 

    Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
    @MiguelCompany
    MiguelCompany committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    9ab899a View commit details
    Browse the repository at this point in the history