Change the order of destruction to prevent use of released objects [14737]

[shumov-ag]

Signed-off-by: Artem Shumov agshumov@sberautotech.ru

This PR changes the order of destruction of StatefulWriter members.
We need to disable all timed events before calling function deinit(), because deinit() releases all cache changes but callbacks of the timed events still use them.

Description

Contributor Checklist

• Commit messages follow the project guidelines.
• The code follows the style guidelines of this project.
• N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
• N/A: Any new/modified methods have been properly documented using Doxygen.
• Fast DDS test suite has been run locally.
• Changes are ABI compatible.
• Changes are API compatible.
• Documentation builds and tests pass locally.
• N/A: New feature has been added to the versions.md file (if applicable).
• N/A: New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

• Check contributor checklist is correct.
• Check CI results: changes do not issue any warning.
• Check CI results: failing tests are unrelated with the changes.

[EduPonz]

This LGTM, thanks @shumov-ag!! I've added an extra commit to delete all the events one after the other just for getting a tidier code. I've also rebased the PR to master, let's see what CI says 😃

[EduPonz]

LGTM

[EduPonz]

@Mergifyio backport 2.5.x

[mergify]

backport 2.5.x

✅ Backports have been created

• #2714 Change the order of destruction to prevent use of released objects [14737] (backport #2642) has been created for branch 2.5.x