Fix warning when converting string to Time_t. #2399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Time_t nanosec() method requires a uint32_t to be passed in. But the previous code was using an int32_t for the nanoseconds, which was causing a warning in some compilers. Fix this by using a uint32_t for the nano variable. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
@Mergifyio backport 2.4.x master |
🟠 Waiting for conditions to match
|
|
Failures are unrelated. |
mergify bot
pushed a commit
that referenced
this pull request
Jan 12, 2022
The Time_t nanosec() method requires a uint32_t to be passed in. But the previous code was using an int32_t for the nanoseconds, which was causing a warning in some compilers. Fix this by using a uint32_t for the nano variable. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> (cherry picked from commit b5f7fbf)
|
Thank you @clalancette for your contribution |
mergify bot
pushed a commit
that referenced
this pull request
Jan 12, 2022
The Time_t nanosec() method requires a uint32_t to be passed in. But the previous code was using an int32_t for the nanoseconds, which was causing a warning in some compilers. Fix this by using a uint32_t for the nano variable. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> (cherry picked from commit b5f7fbf)
✅ Backports have been created
|
|
@Mergifyio backport 2.1.x |
mergify bot
pushed a commit
that referenced
this pull request
Jan 12, 2022
The Time_t nanosec() method requires a uint32_t to be passed in. But the previous code was using an int32_t for the nanoseconds, which was causing a warning in some compilers. Fix this by using a uint32_t for the nano variable. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> (cherry picked from commit b5f7fbf)
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Time_t nanosec() method requires a uint32_t to be passed in.
But the previous code was using an int32_t for the nanoseconds,
which was causing a warning in some compilers. Fix this by
using a uint32_t for the nano variable.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
Note that I targeted this at the 2.3.x branch, which is where I noticed it (using ROS 2 Rolling). I'm happy to retarget it to master if preferred (though I'll then ask for a backport to 2.3.x).