Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistence guid hotfixes [12680] (backport #2244) #2301

Merged
merged 2 commits into from
Nov 3, 2021

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 2, 2021

This is an automatic backport of pull request #2244 done by Mergify.
Cherry-pick of 7280e1d has failed:

On branch mergify/bp/2.3.x/pr-2244
Your branch is up to date with 'origin/2.3.x'.

You are currently cherry-picking commit 7280e1de2.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   src/cpp/rtps/builtin/discovery/participant/PDP.cpp
	modified:   src/cpp/rtps/participant/RTPSParticipantImpl.cpp
	modified:   src/cpp/rtps/reader/RTPSReader.cpp
	modified:   src/cpp/rtps/reader/StatefulReader.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   src/cpp/rtps/participant/RTPSParticipantImpl.h

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

* Refs #12522: Set persistence guid correctly

Signed-off-by: jparisu <javierparis@eprosima.com>

* Refs #12522: Eliminate sporious records in RTPSReader

Signed-off-by: jparisu <javierparis@eprosima.com>

* Refs #12522: Avoid creating proxies from death participants

Signed-off-by: jparisu <javierparis@eprosima.com>

* Refs #12522: fix in record update

Signed-off-by: jparisu <javierparis@eprosima.com>

* Refs #12522: uncrustify

Signed-off-by: jparisu <javierparis@eprosima.com>

* Refs #12522: Refix History State

Signed-off-by: jparisu <javierparis@eprosima.com>

* Refs #12522: fix typos in comment

Signed-off-by: jparisu <javierparis@eprosima.com>
(cherry picked from commit 7280e1d)

# Conflicts:
#	src/cpp/rtps/participant/RTPSParticipantImpl.h
@mergify mergify bot added the conflicts Backport PR wich git cherry pick failed label Nov 2, 2021
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany removed the conflicts Backport PR wich git cherry pick failed label Nov 2, 2021
@MiguelCompany MiguelCompany added this to the v2.3.5 milestone Nov 2, 2021
@MiguelCompany MiguelCompany merged commit ad09169 into 2.3.x Nov 3, 2021
@MiguelCompany MiguelCompany deleted the mergify/bp/2.3.x/pr-2244 branch November 3, 2021 06:20
@rsanchez15
Copy link
Contributor

@Mergifyio backport 2.1.x

mergify bot added a commit that referenced this pull request Mar 22, 2022
* Persistence guid hotfixes (#2244)

* Refs #12522: Set persistence guid correctly

Signed-off-by: jparisu <javierparis@eprosima.com>

* Refs #12522: Eliminate sporious records in RTPSReader

Signed-off-by: jparisu <javierparis@eprosima.com>

* Refs #12522: Avoid creating proxies from death participants

Signed-off-by: jparisu <javierparis@eprosima.com>

* Refs #12522: fix in record update

Signed-off-by: jparisu <javierparis@eprosima.com>

* Refs #12522: uncrustify

Signed-off-by: jparisu <javierparis@eprosima.com>

* Refs #12522: Refix History State

Signed-off-by: jparisu <javierparis@eprosima.com>

* Refs #12522: fix typos in comment

Signed-off-by: jparisu <javierparis@eprosima.com>
(cherry picked from commit 7280e1d)

# Conflicts:
#	src/cpp/rtps/participant/RTPSParticipantImpl.h

* Fixed backport conflicts

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Co-authored-by: jparisu <69341543+jparisu@users.noreply.github.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit ad09169)
@mergify
Copy link
Contributor Author

mergify bot commented Mar 22, 2022

backport 2.1.x

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants