Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incosistences between Pub/Sub history and RTPS history [12620] (backport #2239) #2296

Merged
merged 2 commits into from
Mar 18, 2022

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 27, 2021

This is an automatic backport of pull request #2239 done by Mergify.
Cherry-pick of 6003592 has failed:

On branch mergify/bp/2.3.x/pr-2239
Your branch is up to date with 'origin/2.3.x'.

You are currently cherry-picking commit 6003592fd.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   include/fastdds/rtps/history/History.h
	modified:   include/fastdds/rtps/history/ReaderHistory.h
	modified:   include/fastrtps/subscriber/SubscriberHistory.h
	modified:   src/cpp/fastrtps_deprecated/subscriber/SubscriberHistory.cpp
	modified:   src/cpp/rtps/history/ReaderHistory.cpp
	modified:   src/cpp/rtps/reader/StatefulReader.cpp
	modified:   test/blackbox/common/BlackboxTests.hpp
	new file:   test/blackbox/types/KeyedData1mb.cpp
	new file:   test/blackbox/types/KeyedData1mb.h
	new file:   test/blackbox/types/KeyedData1mb.idl
	new file:   test/blackbox/types/KeyedData1mbType.cpp
	new file:   test/blackbox/types/KeyedData1mbType.h
	modified:   test/blackbox/utils/data_generators.cpp
	modified:   test/blackbox/utils/lambda_functions.cpp
	modified:   test/blackbox/utils/print_functions.cpp
	modified:   test/mock/rtps/ReaderHistory/fastdds/rtps/history/ReaderHistory.h

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   test/blackbox/CMakeLists.txt
	both modified:   test/blackbox/common/BlackboxTestsPubSubFragments.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

* Refs #12161. Add test large fragmented samples with key

Signed-off-by: Ricardo González <ricardo@richiware.dev>

* Refs #12161. Fix deserializing not completed sample

Signed-off-by: Ricardo González <ricardo@richiware.dev>

* Refs #12161. Fix inconsistence between histories

Signed-off-by: Ricardo González <ricardo@richiware.dev>

* Refs #12161. Fix uncrustify

Signed-off-by: Ricardo González <ricardo@richiware.dev>

* Refs 12620. Added override on overriden method.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Added new virtual method to ReaderHistory mock

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs 12620. Uncrustify.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 6003592)

# Conflicts:
#	test/blackbox/CMakeLists.txt
#	test/blackbox/common/BlackboxTestsPubSubFragments.cpp
@mergify mergify bot added the conflicts Backport PR wich git cherry pick failed label Oct 27, 2021
@MiguelCompany
Copy link
Member

@richiware Would you mind fixing the conflicts here?

@MiguelCompany MiguelCompany added this to the v2.3.5 milestone Nov 4, 2021
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware
Copy link
Member

@richiware Would you mind fixing the conflicts here?

@MiguelCompany Fixed conflict

Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany MiguelCompany removed the conflicts Backport PR wich git cherry pick failed label Jan 21, 2022
@MiguelCompany
Copy link
Member

@richiprosima Please test this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants