Correct iterator increment after erasing elements in `connected_serve…

…rs_list` (#5226)

* BugFix: Correct iterator increment after erasing elements in connected_servers_ list

Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>

* Refs #21649. Apply suggested changes

Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>

---------

Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>

src/cpp/rtps/builtin/discovery/participant/PDPClient.cpp

@@ -594,15 +594,21 @@ void PDPClient::removeRemoteEndpoints(
         eprosima::shared_lock<eprosima::shared_mutex> disc_lock(mp_builtin->getDiscoveryMutex());
 
         // Verify if this participant is a server
-        for (auto it = connected_servers_.begin(); it != connected_servers_.end(); ++it)
+        auto it = connected_servers_.begin();
+        while (it != connected_servers_.end())
         {
             if (it->guidPrefix == pdata->m_guid.guidPrefix)
             {
                 std::unique_lock<std::recursive_mutex> lock(*getMutex());
                 it = connected_servers_.erase(it);
                 is_server = true;
                 mp_sync->restart_timer(); // enable announcement and sync mechanism till this server reappears
+
+                // Avoid incrementing iterator after item removal
+                continue;
             }
+
+            ++it;
         }
     }