Skip to content

Commit

Permalink
Clarified CacheChange reservation failure message (#2824)
Browse files Browse the repository at this point in the history
* Refs #15119: Lowered severity and clarified message of log trace returned when trying to reserve a CacheChange when QoS limits have been reached

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>

* Refs #15119: Applied suggestions

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
  • Loading branch information
jsan-rt authored Jul 27, 2022
1 parent 2e45979 commit 2878f4e
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 3 additions & 1 deletion src/cpp/rtps/reader/StatefulReader.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -540,7 +540,9 @@ bool StatefulReader::processDataMsg(
CacheChange_t* change_to_add = nullptr;
if (!change_pool_->reserve_cache(change_to_add))
{
logError(RTPS_MSG_IN, IDSTRING "Problem reserving CacheChange in reader: " << m_guid);
logWarning(RTPS_MSG_IN,
IDSTRING "Reached the maximum number of samples allowed by this reader's QoS. Rejecting change for reader: " <<
m_guid );
return false;
}

Expand Down
4 changes: 3 additions & 1 deletion src/cpp/rtps/reader/StatelessReader.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,9 @@ bool StatelessReader::processDataMsg(
CacheChange_t* change_to_add = nullptr;
if (!change_pool_->reserve_cache(change_to_add))
{
logError(RTPS_MSG_IN, IDSTRING "Problem reserving CacheChange in reader: " << m_guid);
logWarning(RTPS_MSG_IN,
IDSTRING "Reached the maximum number of samples allowed by this reader's QoS. Rejecting change for reader: " <<
m_guid );
return false;
}

Expand Down

0 comments on commit 2878f4e

Please sign in to comment.