Add instructions for building and running Fast-DDS on QNX 7.1 #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
jsan-rt
suggested changes
Mar 27, 2023
There was a problem hiding this comment.
Thanks for the contribution. I've managed to cross compile the library successfully following these steps with just one minor issue (the environment script had to be sourced instead of run).
I've made a few rewording suggestions since we tend to use reported speech and a more impersonal approach on our documentation. Feel free to rewrite them in your own style following that as you see fit.
… for QNX 7.1 Signed-off-by: James Choi <chachoi@blackberry.com>
chachoi
force-pushed
the
feature/QNX_7.1
branch
from
71803c3
to
7f5ad98
Compare
|
Thank you @jsantiago-eProsima for the feedback. I fixed my PR accordingly. |
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
jsan-rt
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added instructions for building Fast-DDS and running its tests and examples for QNX 7.1.
This PR is related to the PR which adds support to QNX 7.1.
Any feedback is appreciated.