Added caching for GetAccessToken() method #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this repo actively maintained? this PR has been outstanding since october last year |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My application is storing long lived USER refresh token and using the GetAccessToken method to fetch USER token on demand.
The access token returned from GetAccessToken method is valid for 2 hours. If GetAccessToken is called within 1 hour and 55 minutes, there is no need fetch another access token.
It looks like caching applies to Application type access token and is not handling User type token.
Also, do you think MemoryCache with an absolute expiration policy might be a better implementation for this piece?