Assert that users have no passwords in anonymize command #2179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardebeling
force-pushed
the
anonymize-passwords
branch
from
8f2016b
to
af80538
Compare
richardebeling
force-pushed
the
anonymize-passwords
branch
from
af80538
to
3e648ee
Compare
niklasmohrin
approved these changes
May 14, 2024
Anonymized data (possibly intended for publishing) should not contain any real password hashes. If we expected users to have passwords stored in our database, we would have to replace them. Since we don't expect users to have any password set, it felt more natural to me to just assert that this expectation holds (and we thus don't leak any critical data). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.