Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't sort course_evaluations in results_evaluation_detail.html again #2154

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

richardebeling
Copy link
Member

It is already sorted in the view:

course_evaluations.sort(key=lambda evaluation: evaluation.name)

@niklasmohrin
Copy link
Member

Removing the .sort line does not fail any tests, should we add one?

@richardebeling
Copy link
Member Author

Removing the .sort line does not fail any tests, should we add one?

Done. It's a bit annoying, the test runs for ~400ms. 70ms for results computation/caching, 280ms for rendering the page. I guess its a performance problem with the view, though, the test itself is fine I think.

@richardebeling richardebeling merged commit 92a92b5 into e-valuation:main Apr 5, 2024
12 checks passed
@richardebeling richardebeling deleted the duplicated-sorting branch April 5, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants