-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix generation of JS translations by dropping old locale folder #2078
Fix generation of JS translations by dropping old locale folder #2078
Conversation
f905658
to
26b9bba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is looking good, works for me locally (after ensuring that the the locale
folder was indeed removed and not kept because there is an untracked old djangojs.po
in there), thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 👍
8bea728
to
8838e81
Compare
8838e81
to
aa83856
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks :)
🥳 |
locale
directory within the source base is considered as a directory for storing *.po files bymakemessages
[1]. This causes thedjangojs.po
file to be created in the wrong folder by./manage.py translate
. As a workaround, we can rename or remove ourlocale
folder in the static files.moment_de.js
file is just included once in the datetimepicker html file, so we can change its path there.[1] https://github.com/django/django/blob/main/django/core/management/commands/makemessages.py#L565