-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace (some) jQuery code with native javascript #2013
Replace (some) jQuery code with native javascript #2013
Conversation
f2e548e
to
9c5eb4f
Compare
I don't think we can replicate |
If you want, you can also leave the modals unchanged and I take of them in the other PR. I havent exactly figured out how to deal with the "shared modals" business yet and wanted to think about that later, so if you have ideas / solutions I will gladly take them |
Yeah I decided that I will not bother with the actual base modal implementation in this PR, since that's what you are currently changing. |
The |
fa4bf43
to
316a5e8
Compare
316a5e8
to
1e9615a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good, some nits:
These were leftovers from #2013 where I forgot to remove them.
These places are left, but they will have to be done in separate PRs:
makeFormSortable
/rowChanged
/rowAdded
-- I think this is enough for a separate PR.unbind
method call.Todo:
slow
in changes)assert
andfadeOutThenRemove
fromutils.ts
andCSRF_HEADERS
fromcsrf_utils.ts
.base.html
includesutils
to make these available globally.