Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TextAnswer anonymization #1811

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Fix TextAnswer anonymization #1811

merged 1 commit into from
Oct 4, 2022

Conversation

janno42
Copy link
Member

@janno42 janno42 commented Sep 26, 2022

fixes #1798

niklasmohrin
niklasmohrin approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@niklasmohrin niklasmohrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose that works :D I think we should add a comment explaining these lines, because they seem a bit arbitrary otherwise

richardebeling
richardebeling approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@richardebeling richardebeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @niklasmohrin. I'd suggest a simple "These can't be identical, see #issue number" comment.

@janno42 janno42 merged commit 0b805f4 into e-valuation:main Oct 4, 2022
@janno42 janno42 deleted the fix-1798 branch October 4, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardebeling richardebeling richardebeling approved these changes

@niklasmohrin niklasmohrin niklasmohrin approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Anonymize can fail when replacing TextAnswers
3 participants
@janno42 @richardebeling @niklasmohrin