Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add badge with textanswer count per question on results pages #1775

Merged
merged 2 commits into from
Jul 18, 2022
Merged

add badge with textanswer count per question on results pages #1775

merged 2 commits into from
Jul 18, 2022

Conversation

janno42
Copy link
Member

@janno42 janno42 commented Jul 4, 2022

No description provided.

richardebeling
richardebeling approved these changes Jul 4, 2022
View reviewed changes
Copy link
Member

@richardebeling richardebeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks fine, haven't manually tested.

niklasmohrin
niklasmohrin reviewed Jul 18, 2022
View reviewed changes
Copy link
Member

@niklasmohrin niklasmohrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want this to happen:
image

Its not like it is overlapping or so, just a bit odd - I am fine with leaving it this way though

@janno42 janno42 merged commit e8862e1 into e-valuation:main Jul 18, 2022
@janno42 janno42 deleted the textanswer-count branch July 18, 2022 20:18
Kakadus pushed a commit to Kakadus/EvaP that referenced this pull request Jul 25, 2022
@janno42
add badge with textanswer count per question on results pages (e-valu…
2deaa69 
…ation#1775)

* add badge with textanswer count per question on results pages

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklasmohrin niklasmohrin niklasmohrin left review comments

@richardebeling richardebeling richardebeling approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@janno42 @richardebeling @niklasmohrin